Bug 75847 - Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html
Summary: Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 05:46 PST by Csaba Osztrogonác
Modified: 2012-01-09 09:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2012-01-09 05:58 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-01-09 05:46:38 PST 
fast/dom/insertAdjacentHTML-DocumentFragment-crash.html introduced in http://trac.webkit.org/changeset/104441.

We got the following diffs on jsc platforms (SL, GTK, Qt):
--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/insertAdjacentHTML-DocumentFragment-crash-actual.txt 
@@ -1,2 +1,2 @@
-CONSOLE MESSAGE: line 9: Uncaught Error: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7
+CONSOLE MESSAGE: line 9: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7: An attempt was made to modify an object where modifications are not allowed.
 This test passes if it doesn't crash (or ASSERT).

It seesm it is a jsc/v8 difference. As far as I remember there were a consensus on 
webkit-dev that jsc results should be committed as platform independent expected file.
Comment 1 Csaba Osztrogonác 2012-01-09 05:58:57 PST 
Created attachment 121651 [details]
Patch
Comment 2 Philippe Normand 2012-01-09 06:00:49 PST 
Comment on attachment 121651 [details]
Patch

Thanks!
Comment 3 Csaba Osztrogonác 2012-01-09 06:05:35 PST 
Comment on attachment 121651 [details]
Patch

Clearing flags on attachment: 121651

Committed r104454: <http://trac.webkit.org/changeset/104454>
Comment 4 Csaba Osztrogonác 2012-01-09 06:05:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2012-01-09 09:04:28 PST 
Ah, sorry.  Silly v8