WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75847
Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html
https://bugs.webkit.org/show_bug.cgi?id=75847
Summary
Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment...
Csaba Osztrogonác
Reported
2012-01-09 05:46:38 PST
fast/dom/insertAdjacentHTML-DocumentFragment-crash.html introduced in
http://trac.webkit.org/changeset/104441
. We got the following diffs on jsc platforms (SL, GTK, Qt): --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/insertAdjacentHTML-DocumentFragment-crash-actual.txt @@ -1,2 +1,2 @@ -CONSOLE MESSAGE: line 9: Uncaught Error: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7 +CONSOLE MESSAGE: line 9: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7: An attempt was made to modify an object where modifications are not allowed. This test passes if it doesn't crash (or ASSERT). It seesm it is a jsc/v8 difference. As far as I remember there were a consensus on webkit-dev that jsc results should be committed as platform independent expected file.
Attachments
Patch
(2.13 KB, patch)
2012-01-09 05:58 PST
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2012-01-09 05:58:57 PST
Created
attachment 121651
[details]
Patch
Philippe Normand
Comment 2
2012-01-09 06:00:49 PST
Comment on
attachment 121651
[details]
Patch Thanks!
Csaba Osztrogonác
Comment 3
2012-01-09 06:05:35 PST
Comment on
attachment 121651
[details]
Patch Clearing flags on attachment: 121651 Committed
r104454
: <
http://trac.webkit.org/changeset/104454
>
Csaba Osztrogonác
Comment 4
2012-01-09 06:05:45 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 5
2012-01-09 09:04:28 PST
Ah, sorry. Silly v8
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug