Bug 75837 - [EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization.
Summary: [EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor ref...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 02:04 PST by Tomasz Morawski
Modified: 2012-01-10 07:18 PST (History)
4 users (show)

See Also:


Attachments
Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization (4.61 KB, patch)
2012-01-09 02:05 PST, Tomasz Morawski
rniwa: review+
Details | Formatted Diff | Diff
Fixed ChangeLog (4.56 KB, patch)
2012-01-10 05:54 PST, Tomasz Morawski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Morawski 2012-01-09 02:04:25 PST
Changes:
- Changed graphicContext raw pointer to OwnPtr smart pointer.
- Changed cr variable name to cairo and making it as RefPtr.
Comment 1 Tomasz Morawski 2012-01-09 02:05:45 PST
Created attachment 121633 [details]
Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-01-09 05:10:20 PST
Looks OK.
Comment 3 Gyuyoung Kim 2012-01-09 05:14:19 PST
Comment on attachment 121633 [details]
Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization

LGTM too.
Comment 4 Ryosuke Niwa 2012-01-10 00:37:33 PST
Comment on attachment 121633 [details]
Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization

View in context: https://bugs.webkit.org/attachment.cgi?id=121633&action=review

> Source/WebKit/efl/ChangeLog:3
> +        [EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization.

Nit: minor "refactoring"

> Source/WebKit/efl/ChangeLog:9
> +        Changed cr variable name to cairo and making it as RefPtr.

Nit: Renamed cr to cairo and made it a RefPtr.
Comment 5 Tomasz Morawski 2012-01-10 05:54:04 PST
Created attachment 121837 [details]
Fixed ChangeLog
Comment 6 WebKit Review Bot 2012-01-10 07:18:05 PST
Comment on attachment 121837 [details]
Fixed ChangeLog

Clearing flags on attachment: 121837

Committed r104568: <http://trac.webkit.org/changeset/104568>
Comment 7 WebKit Review Bot 2012-01-10 07:18:10 PST
All reviewed patches have been landed.  Closing bug.