Bug 75828 - [Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGeneratorV8.pm
Summary: [Refactoring] Use join(", ", @arguments) to build a method argument string in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency tree / graph
 
Reported: 2012-01-08 23:34 PST by Kentaro Hara
Modified: 2012-01-09 00:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2012-01-08 23:39 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-08 23:34:21 PST 
This is a refactoring for implementing the [Supplemental] IDL for methods (bug 72138).

The code in CodeGeneratorV8.pm to build a method argument string is dirty and error-prone. It is concatenating arguments one by one judging whether ", " is necessary or not. Instead, we should refactor the code so that it pushes all arguments into @arguments and then build a method string by join(", ", @arguments).
Comment 1 Kentaro Hara 2012-01-08 23:39:41 PST 
Created attachment 121625 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-09 00:26:36 PST 
Comment on attachment 121625 [details]
Patch

Clearing flags on attachment: 121625

Committed r104438: <http://trac.webkit.org/changeset/104438>
Comment 3 WebKit Review Bot 2012-01-09 00:26:41 PST 
All reviewed patches have been landed.  Closing bug.