Bug 75827 - Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
Summary: Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-08 22:54 PST by Benjamin Poulain
Modified: 2012-01-08 23:15 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2012-01-08 22:57 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-01-08 22:54:11 PST 
I have this local fix on my laptop. I don't know why I am the only one with the issue, on only on this particular computer...

Here is error I get without the patch:
/Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm: In function 'NSTimeInterval systemUptime()':
/Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85: warning: missing initializer for member 'timeval::tv_sec'
/Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85: warning: missing initializer for member 'timeval::tv_usec'

Anyway, the fix seems harmless so I might as well share....
Comment 1 Benjamin Poulain 2012-01-08 22:57:52 PST 
Created attachment 121621 [details]
Patch
Comment 2 Darin Adler 2012-01-08 23:00:49 PST 
Comment on attachment 121621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121621&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85
> +    static struct timeval boottime = {0, 0};

Since statics are initialized to zero anyway, this could instead just be:

    static struct timeval boottime;
Comment 3 WebKit Review Bot 2012-01-08 23:15:27 PST 
Comment on attachment 121621 [details]
Patch

Clearing flags on attachment: 121621

Committed r104435: <http://trac.webkit.org/changeset/104435>
Comment 4 WebKit Review Bot 2012-01-08 23:15:31 PST 
All reviewed patches have been landed.  Closing bug.