RESOLVED FIXED Bug 75827
Build fix: ScrollAnimatorMac has missing initializer in systemUptime() 
https://bugs.webkit.org/show_bug.cgi?id=75827
Summary Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
Benjamin Poulain
Reported 2012-01-08 22:54:11 PST
I have this local fix on my laptop. I don't know why I am the only one with the issue, on only on this particular computer... Here is error I get without the patch: /Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm: In function 'NSTimeInterval systemUptime()': /Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85: warning: missing initializer for member 'timeval::tv_sec' /Users/benjamin/dev/WebKit.git/Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85: warning: missing initializer for member 'timeval::tv_usec' Anyway, the fix seems harmless so I might as well share....
Attachments
Patch (1.50 KB, patch)
2012-01-08 22:57 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-01-08 22:57:52 PST
Created attachment 121621 [details] Patch
Darin Adler
Comment 2 2012-01-08 23:00:49 PST
Comment on attachment 121621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121621&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:85 > + static struct timeval boottime = {0, 0}; Since statics are initialized to zero anyway, this could instead just be: static struct timeval boottime;
WebKit Review Bot
Comment 3 2012-01-08 23:15:27 PST
Comment on attachment 121621 [details] Patch Clearing flags on attachment: 121621 Committed r104435: <http://trac.webkit.org/changeset/104435>
WebKit Review Bot
Comment 4 2012-01-08 23:15:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.