Bug 75823 – background position parsing test for CSS3 calc

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mike Lawther]

background position parsing test for CSS3 calc

[Mike Lawther]

Created attachment 121618 [details]
Patch

[Daniel Bates]

Comment on attachment 121618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121618&action=review

> LayoutTests/css3/calc/background-position-parsing-expected-mismatch.html:1
> +<!-- Note: This test is borrowed from [e-mail]'s "CSS background position: parsing" test -->

How can you borrow a test? I take it that you mean that this test is a deriviative of one of Ian's tests. Which "CSS background position: parsing" test? Briefly using google I found the following tests: <http://hixie.ch/tests/adhoc/css/background/position>. Also, is there are version/date information for the original test? When was the original test accessed? I suggest using a more formal citation as a way to document when this derivative was created and what version of the original test was it based on.

On another note, Ian's tests appear to be bound by the license <http://hixie.ch/tests/LICENSE>. This license states, among other conditions, that "you may use [the tests] as you see fit, including making changes. You may not, however, redistribute them or any derivative works in any form." Is the WebKit.org repository exempt from the redistribution clause?

[Daniel Bates]

Comment on attachment 121618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121618&action=review

>> LayoutTests/css3/calc/background-position-parsing-expected-mismatch.html:1
>> +<!-- Note: This test is borrowed from [e-mail]'s "CSS background position: parsing" test -->
> 
> How can you borrow a test? I take it that you mean that this test is a deriviative of one of Ian's tests. Which "CSS background position: parsing" test? Briefly using google I found the following tests: <http://hixie.ch/tests/adhoc/css/background/position>. Also, is there are version/date information for the original test? When was the original test accessed? I suggest using a more formal citation as a way to document when this derivative was created and what version of the original test was it based on.
> 
> On another note, Ian's tests appear to be bound by the license <http://hixie.ch/tests/LICENSE>. This license states, among other conditions, that "you may use [the tests] as you see fit, including making changes. You may not, however, redistribute them or any derivative works in any form." Is the WebKit.org repository exempt from the redistribution clause?

Also, what is the DOCTYPE for this test?

[Mike Lawther]

Comment on attachment 121618 [details]
Patch

Yes - it is a derivative (s/borrowed/derived/ in the comment). The test I derived from is in WebKit at LayoutTests/fast/backgrounds/background-position-parsing.html.  I did not realise it was bound by a licence that affected derived works or distribution - I did not see a licence clause in the test checked into WebKit.

I can certainly restore the expected file to be identical to LayoutTests/fast/backgrounds/background-position-parsing.html, but then I guess I'm stymied by the non-distribution of derived works (which the test file with -webkit-calc would be).

As for DOCTYPE, I had previously been told not that DOCTYPE was unnecessary in a WebKit layout test, so I didn't include it.

[Ian 'Hixie' Hickson]

Feel free to use that test under the BSD license.

[Daniel Bates]

(In reply to comment #4)
> (From update of attachment 121618 [details])
> [...]
> As for DOCTYPE, I had previously been told not that DOCTYPE was unnecessary in a WebKit layout test, so I didn't include it.

It's not necessary but it's preferred to include a DOCTYPE, especially for valid HTML5 documents.

[Mike Lawther]

Created attachment 121768 [details]
Patch

[Mike Lawther]

Hixie - thanks for that!

I've reverted the expected file to be identical to LayoutTests/fast/backgrounds/background-position-parsing.html, and the calc version is the same, except has -webkit-calc() sprinkled through it.

[Daniel Bates]

Comment on attachment 121768 [details]
Patch

Looks good to me.

[WebKit Review Bot]

Comment on attachment 121768 [details]
Patch

Clearing flags on attachment: 121768

Committed r104525: <http://trac.webkit.org/changeset/104525>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.