Bug 75811 – [Chromium] Remove use_skia option from GYP

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[Chromium] Remove use_skia option from GYP

[Adam Barth]

Created attachment 121600 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 121600 [details]
Patch

r=me as long as it builds.

[Adam Barth]

Committed r104418: <http://trac.webkit.org/changeset/104418>

I don't think we should do this yet.  We are still encountering bugs that may or may not be Skia-specific, so it is very helpful to be able to switch it on and off in custom builds.

Can we keep the switch around for another month and then re-evaluate?

Adam/Ryosuke - I have created a rollout CL in https://bugs.webkit.org/show_bug.cgi?id=75855 for the reason stated above.

If it's OK with you, please commit+ the rollout; otherwise, please let me know why it's problematic and then we can figure out the best way to allow developers to test against CG when needed.

I'm not sure how, but the rollback got committed.  Feel free to roll back the rollback if you see fit.

[Adam Barth]

Oh, i marked it for commit.

Eventual cleanup of this tracked in http://crbug.com/110881 ('cleanup: remove use_skia=0 build option')

Reopening to attach new patch.

Created attachment 130438 [details]
Patch

abarth or rniwa: please r+ if it looks good to you (it's pretty much a superset of Adam's original patch)

I will have someone else c+ it tomorrow morning when I can follow its progress as it lands...

[Tony Chang]

Comment on attachment 130438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130438&action=review

> Source/WebKit/chromium/WebKit.gyp:829
> +                # TODO: we exclude CG.cpp on both sides of the below conditional. Move elsewhere?

Can we just delete WebImageCG.cpp and remove the exclude line?  That seems to be the only file this applies to.

(In reply to comment #12)
> (From update of attachment 130438 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130438&action=review
> 
> > Source/WebKit/chromium/WebKit.gyp:829
> > +                # TODO: we exclude CG.cpp on both sides of the below conditional. Move elsewhere?
> 
> Can we just delete WebImageCG.cpp and remove the exclude line?  That seems to be the only file this applies to.

I'll try that as a separate CL, just so I can get the use_skia stuff removed ASAP...

[WebKit Review Bot]

Comment on attachment 130438 [details]
Patch

Clearing flags on attachment: 130438

Committed r110056: <http://trac.webkit.org/changeset/110056>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.