Bug 75808 - The JIT's protocol for exception handling should be available to other parts of the system
Summary: The JIT's protocol for exception handling should be available to other parts ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-01-08 15:05 PST by Filip Pizlo
Modified: 2012-01-08 20:32 PST (History)
3 users (show)

See Also:

Attachments
the patch (14.94 KB, patch)
2012-01-08 15:22 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (14.89 KB, patch)
2012-01-08 15:28 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-01-08 15:05:40 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-01-08 15:06:00 PST 
<rdar://problem/10661025>
Comment 2 Filip Pizlo 2012-01-08 15:22:12 PST 
Created attachment 121594 [details]
the patch
Comment 3 WebKit Review Bot 2012-01-08 15:24:22 PST 
Attachment 121594 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/jit/JITExceptions.h:45:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITExceptions.h:47:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2012-01-08 15:28:02 PST 
Created attachment 121595 [details]
the patch
Comment 5 Filip Pizlo 2012-01-08 15:47:43 PST 
Landed in http://trac.webkit.org/changeset/104415
Comment 6 Ryosuke Niwa 2012-01-08 20:32:27 PST 
WinCE build fix landed in http://trac.webkit.org/changeset/104429.