Bug 75807 - [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
Summary: [Qt] Add support for dynamically enabling and disabling touch mocking in the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Færøy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-08 13:09 PST by Alexander Færøy
Modified: 2012-01-09 06:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (14.36 KB, patch)
2012-01-08 13:26 PST, Alexander Færøy 		no flags Details | Formatted Diff | Diff
Patch (14.46 KB, patch)
2012-01-09 04:30 PST, Alexander Færøy 		no flags Details | Formatted Diff | Diff
Patch (14.38 KB, patch)
2012-01-09 04:58 PST, Alexander Færøy 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Færøy 2012-01-08 13:09:57 PST 
SSIA.
Comment 1 Alexander Færøy 2012-01-08 13:14:08 PST 
Adding Kenneth since him and I discussed this feature at the office.
Comment 2 Alexander Færøy 2012-01-08 13:26:38 PST 
Created attachment 121588 [details]
Patch
Comment 3 Alexander Færøy 2012-01-08 13:27:31 PST 
Adding Tor Arne for review, since he has been hacking on this code recently :-)
Comment 4 Kenneth Rohde Christiansen 2012-01-08 14:28:18 PST 
Are you disabling touch events? or merely turning the touch mocking off?
Comment 5 Alexander Færøy 2012-01-08 15:21:24 PST 
(In reply to comment #4)
> Are you disabling touch events? or merely turning the touch mocking off?

Good point. I am merely disabling the mock up on our desktop systems. I will rename the various methods to reflect reality tomorrow :-)
Comment 6 Alexander Færøy 2012-01-09 04:30:49 PST 
Created attachment 121644 [details]
Patch
Comment 7 Tor Arne Vestbø 2012-01-09 04:39:46 PST 
Comment on attachment 121644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121644&action=review

> Tools/ChangeLog:4
> +        [Qt] Add support for dynamically enabling and disabling of Touch Events in the Qt MiniBrowser
> +        https://bugs.webkit.org/show_bug.cgi?id=75807

disabling _touch mocking_

> Tools/MiniBrowser/qt/MiniBrowserApplication.h:48
> +    Q_PROPERTY(bool mockTouchEventsEnabled READ mockTouchEventsEnabled WRITE setMockTouchEventsEnabled NOTIFY mockTouchEventsEnabledChanged)

I'd prefer the name touchMockingEnabled throughout
Comment 8 Alexander Færøy 2012-01-09 04:58:10 PST 
Created attachment 121647 [details]
Patch
Comment 9 WebKit Review Bot 2012-01-09 06:14:20 PST 
Comment on attachment 121647 [details]
Patch

Clearing flags on attachment: 121647

Committed r104455: <http://trac.webkit.org/changeset/104455>
Comment 10 WebKit Review Bot 2012-01-09 06:14:24 PST 
All reviewed patches have been landed.  Closing bug.