Bug 75807 – [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Alexander Færøy]

SSIA.

[Alexander Færøy]

Adding Kenneth since him and I discussed this feature at the office.

[Alexander Færøy]

Created attachment 121588 [details]
Patch

[Alexander Færøy]

Adding Tor Arne for review, since he has been hacking on this code recently :-)

[Kenneth Rohde Christiansen]

Are you disabling touch events? or merely turning the touch mocking off?

[Alexander Færøy]

(In reply to comment #4)
> Are you disabling touch events? or merely turning the touch mocking off?

Good point. I am merely disabling the mock up on our desktop systems. I will rename the various methods to reflect reality tomorrow :-)

[Alexander Færøy]

Created attachment 121644 [details]
Patch

[Tor Arne Vestbø]

Comment on attachment 121644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121644&action=review

> Tools/ChangeLog:4
> +        [Qt] Add support for dynamically enabling and disabling of Touch Events in the Qt MiniBrowser
> +        https://bugs.webkit.org/show_bug.cgi?id=75807

disabling _touch mocking_

> Tools/MiniBrowser/qt/MiniBrowserApplication.h:48
> +    Q_PROPERTY(bool mockTouchEventsEnabled READ mockTouchEventsEnabled WRITE setMockTouchEventsEnabled NOTIFY mockTouchEventsEnabledChanged)

I'd prefer the name touchMockingEnabled throughout

[Alexander Færøy]

Created attachment 121647 [details]
Patch

[WebKit Review Bot]

Comment on attachment 121647 [details]
Patch

Clearing flags on attachment: 121647

Committed r104455: <http://trac.webkit.org/changeset/104455>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.