Bug 75783 - [Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
Summary: [Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: W. James MacLean
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-07 13:44 PST by Dmitry Lomov
Modified: 2012-01-09 16:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.93 KB, patch)
2012-01-09 11:17 PST, W. James MacLean 		no flags Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2012-01-09 11:32 PST, W. James MacLean 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 W. James MacLean 2012-01-09 08:01:39 PST 
I think this is my fault, I forgot to update this test as part of my tile culling patch - sorry.

The test expectations for this test need to be modified (layer1 should now *not* draw once the opaque layer2 is added, since it is completely occluded by layer2 and thus gets culled). I'll submit a patch this morning, plus add another test case just to confirm that layer1 does draw if layer2 becomes non-opaque.
Comment 2 W. James MacLean 2012-01-09 11:17:38 PST 
Created attachment 121697 [details]
Patch
Comment 3 W. James MacLean 2012-01-09 11:32:42 PST 
Created attachment 121702 [details]
Patch
Comment 4 W. James MacLean 2012-01-09 11:33:13 PST 
Removed "FAILS_".
Comment 5 James Robinson 2012-01-09 15:04:33 PST 
Comment on attachment 121702 [details]
Patch

R=me. I'm surprised EWS bots don't run webkit_unit_tests, will look into that.
Comment 6 WebKit Review Bot 2012-01-09 16:12:33 PST 
Comment on attachment 121702 [details]
Patch

Clearing flags on attachment: 121702

Committed r104505: <http://trac.webkit.org/changeset/104505>
Comment 7 WebKit Review Bot 2012-01-09 16:12:37 PST 
All reviewed patches have been landed.  Closing bug.