Bug 7578 - TinyMCE: Implement execCommand CreateLink
Summary: TinyMCE: Implement execCommand CreateLink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks: 6627
  Show dependency treegraph
 
Reported: 2006-03-03 14:55 PST by Justin Garcia
Modified: 2006-03-14 23:05 PST (History)
0 users

See Also:


Attachments
patch (34.61 KB, patch)
2006-03-14 16:09 PST, Justin Garcia
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2006-03-03 14:55:14 PST
Implement execCommand link and unlink
Comment 1 Justin Garcia 2006-03-09 12:04:07 PST
I'm going to split UnLink off into it's own bug
Comment 2 Justin Garcia 2006-03-14 16:09:47 PST
Created attachment 7066 [details]
patch

Another way to do this would be to pull out the parts of ApplyStyleCommand that apply style to text runs from the parts that do the setup, traversal and cleanup, and make two new classes, PushInlineChangeCommand and ApplyInlineStyleCommand, with CreateLink and ApplyinlineStyleCommand as subclasses of PushInlineChangeCommand.  That's more risky and probably not worth the effort unless we think we'll end up needing PushInlineChange in order to implement something else.
Comment 3 Maciej Stachowiak 2006-03-14 21:27:20 PST
Comment on attachment 7066 [details]
patch

Slighly odd way to do it. r=me