Bug 75773 - [GTK] Enable requestAnimationFrame in build-webkit
Summary: [GTK] Enable requestAnimationFrame in build-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-07 01:28 PST by Zan Dobersek
Modified: 2012-01-09 00:55 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2012-01-07 01:41 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-01-07 01:28:49 PST
requestAnimationFrame should be enabled in the developer builds for the Gtk port. Currently the timer-based implementation will be used, but should be replaced by a more complete solution (vsync-like). All the relevant layout tests pass, except for a test that utilizes modal dialogs, for which the Gtk port does not have support yet.

After the patch lands, clean builds will be required on the bots.
Comment 1 Zan Dobersek 2012-01-07 01:41:37 PST
Created attachment 121543 [details]
Patch

Enable the feature and unskip the passing tests.
Comment 2 Zan Dobersek 2012-01-07 01:45:57 PST
Requesting a review.
Comment 3 WebKit Review Bot 2012-01-07 09:18:30 PST
Comment on attachment 121543 [details]
Patch

Clearing flags on attachment: 121543

Committed r104386: <http://trac.webkit.org/changeset/104386>
Comment 4 WebKit Review Bot 2012-01-07 09:18:34 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2012-01-08 16:09:12 PST
It seems like this patch broke GTK+ builds:
http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/20601
Comment 6 Zan Dobersek 2012-01-09 00:55:07 PST
(In reply to comment #5)
> It seems like this patch broke GTK+ builds:
> http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/20601

It probably did as a clean build is required. I do not have access to the linked buildbot, though, but I'm sure someone will poke it today.