WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75766
Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766
Summary
Categorize bots by ports instead of core/non-core separation
Ryosuke Niwa
Reported
2012-01-06 20:55:54 PST
This comes up every now and then on IRC but we should just get rid of core/non-core separation. People misuse it to think it's okay to turn non-core bots red and some people don't even pay attention to core bots. Also, many core bots have been red for months and nobody has took time to fix it. And having to modify master configuration to move a bot from core to non-core is too annoying. Instead, we should just categorize bots per ports (Mac, Windows, GTK, Qt, Chromium, and others) since people care about their own ports' bots and they tend to ping patch authors/reviewers to have them fix new failures.
Attachments
screenshot of category=Chromium
(71.60 KB, image/png)
2012-01-08 15:14 PST
,
Ryosuke Niwa
no flags
Details
Patch
(4.26 KB, patch)
2012-01-08 15:16 PST
,
Ryosuke Niwa
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-01-08 15:14:09 PST
Created
attachment 121592
[details]
screenshot of category=Chromium
Ryosuke Niwa
Comment 2
2012-01-08 15:16:45 PST
Created
attachment 121593
[details]
Patch
Ryosuke Niwa
Comment 3
2012-01-08 15:17:50 PST
I'll remove the remaining references to core/non-core concepts in webkitpy in a follow up patch.
Adam Barth
Comment 4
2012-01-08 15:18:56 PST
Comment on
attachment 121593
[details]
Patch This might be somewhat controversial, but I this sounds like a good idea to me.
Ryosuke Niwa
Comment 5
2012-01-08 15:28:30 PST
Committed
r104413
: <
http://trac.webkit.org/changeset/104413
>
Ryosuke Niwa
Comment 6
2012-01-08 16:32:06 PST
Committed
r104420
: <
http://trac.webkit.org/changeset/104420
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug