RESOLVED WONTFIX 75764
webkitpy: clean up version handling logic in port constructors 
https://bugs.webkit.org/show_bug.cgi?id=75764
Summary webkitpy: clean up version handling logic in port constructors
Dirk Pranke
Reported 2012-01-06 18:11:26 PST
webkitpy: clean up version handling logic in port constructors
Attachments
Patch (119.13 KB, patch)
2012-01-06 18:14 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-01-06 18:14:31 PST
Created attachment 121529 [details] Patch
Dirk Pranke
Comment 2 2012-01-06 18:30:08 PST
just posting this to give a view of the stop on the way ... this patch pushes all of the os version parsing into platforminfo.py, and removes it from the Port constructors (which will now take fully-specified port names). I need to break this large patch up into a bunch of smaller, more easily digestible ones. The final shape of factory.py is still up in the air. My current thinking is that the factory only needs to know a list of classes and can run some sort of generic algorithm over the list of classes given a host and an options argument to figure out a unique port object to construct, but I haven't figured out what that algorithm will be yet. I think ideally adding a new Port implementation should be a matter of adding one entry to a list in factory.py, and should not need the big, hard-to-understand switch statement.
Dirk Pranke
Comment 3 2012-01-10 17:55:40 PST
closing .. this is geting addressed by individual patches tracked by bug 75037.
Note You need to log in before you can comment on or make changes to this bug.