Bug 75763 - [chromium] Add setting for painting debug info onto tiles
Summary: [chromium] Add setting for painting debug info onto tiles
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on: 87647
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-06 17:53 PST by Adrienne Walker
Modified: 2012-05-29 14:37 PDT (History)
9 users (show)

See Also:


Attachments
Patch (13.12 KB, patch)
2012-01-06 17:56 PST, Adrienne Walker
no flags Details | Formatted Diff | Diff
Rebased (11.99 KB, patch)
2012-05-21 15:54 PDT, Adrienne Walker
no flags Details | Formatted Diff | Diff
Cleanup (12.02 KB, patch)
2012-05-25 13:50 PDT, Adrienne Walker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-01-06 17:53:18 PST
[chromium] Add setting for painting debug info onto tiles
Comment 1 Adrienne Walker 2012-01-06 17:56:27 PST
Created attachment 121528 [details]
Patch
Comment 2 Adrienne Walker 2012-01-06 18:00:48 PST
At paint time, this patch prints a block of text onto the layer with some debug information on top of whatever was painted into the layer.  It's useful to do it at paint time partially because you already have a GraphicsContext there, but also because it helps indicate whether invalidation or upload is failing.

This was quite helpful in tracking down http://crbug.com/107769.  I'm not totally sure it's worth piping through to about:flags, so I just left it as a compile-time only flag.

I'm not totally convinced that this should be committed, but jamesr asked for a patch.
Comment 3 WebKit Review Bot 2012-01-07 12:33:26 PST
Comment on attachment 121528 [details]
Patch

Attachment 121528 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11184024

New failing tests:
http/tests/inspector-enabled/dedicated-workers-list.html
compositing/reflections/transform-inside-reflection.html
compositing/geometry/vertical-scroll-composited.html
compositing/geometry/layer-due-to-layer-children.html
compositing/geometry/ancestor-overflow-change.html
css2.1/20110323/abspos-containing-block-initial-004b.htm
compositing/reflections/nested-reflection-transition.html
compositing/direct-image-compositing.html
compositing/shadows/shadow-drawing.html
compositing/geometry/fixed-position-transform-composited-page-scale-down.html
css2.1/20110323/abspos-containing-block-initial-004d.htm
compositing/color-matching/image-color-matching.html
compositing/visibility/visibility-image-layers.html
compositing/geometry/layer-due-to-layer-children-deep.html
compositing/geometry/fixed-position-transform-composited-page-scale.html
compositing/scaling/tiled-layer-recursion.html
Comment 4 Adrienne Walker 2012-01-09 15:09:04 PST
Comment on attachment 121528 [details]
Patch

Removing review flag and leaving this patch up as an FYI for anybody who wants this debugging tool.  I don't think it's worth committing and having to carry forward through future refactorings.
Comment 5 Adrienne Walker 2012-05-21 15:54:43 PDT
Created attachment 143121 [details]
Rebased
Comment 6 Adrienne Walker 2012-05-25 13:50:05 PDT
Created attachment 144140 [details]
Cleanup
Comment 7 Adrienne Walker 2012-05-25 13:51:21 PDT
(In reply to comment #6)
> Created an attachment (id=144140) [details]
> Cleanup

I found this debug info useful again.  Safari has something similar, although they just print out repaint counts.

I think it's worth landing this and afterwards adding a command line flag or yet another about:flags entry.
Comment 8 James Robinson 2012-05-25 14:53:56 PDT
Comment on attachment 144140 [details]
Cleanup

This seems pretty reasonable.
Comment 9 WebKit Review Bot 2012-05-25 15:51:37 PDT
Comment on attachment 144140 [details]
Cleanup

Clearing flags on attachment: 144140

Committed r118580: <http://trac.webkit.org/changeset/118580>
Comment 10 WebKit Review Bot 2012-05-25 15:51:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Marcus Bulach 2012-05-28 04:04:44 PDT
I confirmed this also crashes on linux canaries:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/25948/steps/webkit_unit_tests/logs/stdio

(and a local build with BUILDTYPE=Release also fails with this patch..)

I'll ask the sherrifbot to roll out this patch so that I can roll webkit, I hope it won't cause any trouble..
Comment 13 WebKit Review Bot 2012-05-28 04:06:56 PDT
Re-opened since this is blocked by 87647
Comment 14 Adrienne Walker 2012-05-29 14:37:59 PDT
I'm just going to WONTFIX this and not spend the time addressing the unit test issues that showed up on non-Linux platforms.  It's going to be reverted anyway as a part of GTFO, so it doesn't seem worth the time.