• InspectorDOMAgent::searchingForNodeInPage is missing an implementation. • We should also make setSearchingForNodeInPage public.
Created attachment 121521 [details] [PATCH] Proposed Fix
Comment on attachment 121521 [details] [PATCH] Proposed Fix Clearing flags on attachment: 121521 Committed r104371: <http://trac.webkit.org/changeset/104371>
All reviewed patches have been landed. Closing bug.
(In reply to comment #0) > • InspectorDOMAgent::searchingForNodeInPage is missing an implementation. > • We should also make setSearchingForNodeInPage public. This change is wrong. I was putting a lot of effort into breaking the: WebKit -> InspectorController -> agents control flows. As of now, only front-end should talk to the agents for control. Acting that way we don't need to sync front-end 'inspect mode' state with backend's 'searching for node'. The getter in the header should have been removed along with its implementation (my oversight), while setter should remain private.
Created attachment 121689 [details] [PATCH] Removed Unused Method Reopening based on Pavel's comments. Lets remove the method.
Comment on attachment 121689 [details] [PATCH] Removed Unused Method Cleared review? from attachment 121689 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Apparently the bug wasn't reopened? Resetting flags.
Comment on attachment 121689 [details] [PATCH] Removed Unused Method Thanks for fixing this.
Comment on attachment 121689 [details] [PATCH] Removed Unused Method Clearing flags on attachment: 121689 Committed r104596: <http://trac.webkit.org/changeset/104596>