Bug 75738 – [Mac] Thread verifier assertions when printing

• Status: RESOLVED
• Resolution: FIXED
• Component: Printing

[Alexey Proskuryakov]

We're doing too much from secondary thread. We need it to avoid being blocked on WebProcess, but not to manipulate UI process objects.

[Alexey Proskuryakov]

Created attachment 121484 [details]
proposed fix

I'm not sure if I'm using the right magic to deallocate on main thread (do we need the first part in WK2?)

[Mark Rowe (bdash)]

Comment on attachment 121484 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=121484&action=review

> Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:51
> ++ (void)initialize
> +{
> +    WebCoreObjCFinalizeOnMainThread(self);
> +}

I think this is not necessary in WebKit2.

> Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:127
> +    ASSERT(isMainThread()); // This funciton calls the client, which should only be done on main thread.

"funciton"

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/104334>. Removed WebCoreObjCFinalizeOnMainThread.

> "funciton"

Oops, didn't see this before landing.