Bug 75734 - Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
Summary: Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
Status: RESOLVED DUPLICATE of bug 115653
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks: 73757
  Show dependency tree / graph
 
Reported: 2012-01-06 13:07 PST by Caio Marcelo de Oliveira Filho
Modified: 2013-05-07 09:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.06 KB, patch)
2012-01-06 13:10 PST, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2012-01-06 13:07:56 PST 
Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
Comment 1 Caio Marcelo de Oliveira Filho 2012-01-06 13:10:14 PST 
Created attachment 121480 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-06 17:24:23 PST 
Comment on attachment 121480 [details]
Patch

Clearing flags on attachment: 121480

Committed r104362: <http://trac.webkit.org/changeset/104362>
Comment 3 WebKit Review Bot 2012-01-06 17:24:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Mark Rowe (bdash) 2012-01-06 18:40:55 PST 
This broke the build by introducing a link error.  It results in code trying to find __ZN3WTF6OwnPtrINS_6VectorIPKN7WebCore15SVGPropertyInfoELm0EEEEC1ERKS7_  (WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> >::OwnPtr(WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> > const&)). That's a copy-constructor for OwnPtr.  OwnPtr can't be copied.
Comment 5 Mark Rowe (bdash) 2012-01-06 18:46:36 PST 
Rolled out in r104369.
Comment 6 Mark Rowe (bdash) 2012-01-06 18:47:50 PST 
Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this.
Comment 7 Daniel Bates 2012-01-07 19:13:02 PST 
(In reply to comment #5)
> Rolled out in r104369.

Thank you Mark for looking into the failure and rolling this patch out.
Comment 8 Caio Marcelo de Oliveira Filho 2012-01-09 05:37:21 PST 
(In reply to comment #6)
> Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this.

Thanks for the rollout, Mark. I will look into this.
Comment 9 Darin Adler 2013-05-07 09:14:42 PDT 

*** This bug has been marked as a duplicate of bug 115653 ***