We are missing a return after our platform implementation which means the call to vfprintf(stderr, format, args); at the end of the function is hit.
Created attachment 121468 [details] Fix
Attachment 121468 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 121468 [details] Fix Rejecting attachment 121468 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 53, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/11168054
Comment on attachment 121468 [details] Fix another patch coming from Adam.
Comment on attachment 121468 [details] Fix Return in middle looks strange and could give compile error/warning since the last line is unreachable.
Created attachment 121712 [details] Fix v2 This one adds our platform's log locking feature too.
Comment on attachment 121712 [details] Fix v2 Wrong patch.
Created attachment 121713 [details] Fix v3
Created attachment 121716 [details] Fix v4 Modify to apply against current HEAD
Comment on attachment 121716 [details] Fix v4 View in context: https://bugs.webkit.org/attachment.cgi?id=121716&action=review LGTM > Source/JavaScriptCore/ChangeLog:14 > + uses to ensure that N threads do not trample on each other's logs. Would just say multiple threads.
Comment on attachment 121716 [details] Fix v4 View in context: https://bugs.webkit.org/attachment.cgi?id=121716&action=review LGTM >> Source/JavaScriptCore/ChangeLog:14 >> + uses to ensure that N threads do not trample on each other's logs. > > Would just say multiple threads. Would just say multiple threads.
Comment on attachment 121716 [details] Fix v4 Clearing flags on attachment: 121716 Committed r104491: <http://trac.webkit.org/changeset/104491>
All reviewed patches have been landed. Closing bug.