RESOLVED FIXED75717
[Chromium] Move setVisibleRect() calls for mask and replica layers into calculateDrawTransformAndVisibility()
https://bugs.webkit.org/show_bug.cgi?id=75717
Summary [Chromium] Move setVisibleRect() calls for mask and replica layers into calcu...
Xianzhu Wang
Reported 2012-01-06 11:10:29 PST
This is a followup of bug 72162 - Move setVisibleRect() calls into calculateDrawTransformAndVisibility(). setVisibleRect() calls for mask and replica layers are still in CCLayerTreeHost.cpp but they seem also belong to calculateDrawTransformAndVisibility(). Also some questions (copied from my comments to the patch of bug 72162 after it has been committed): 1. Why setVisibleLayerRect to the whole content bounds of the renderSurfaceLayer instead of the actual visible rect? 2. setVisibleLayerRect() for the replica layer seems lost after the patch.
Attachments
Adrienne Walker
Comment 1 2012-01-06 11:16:47 PST
(In reply to comment #0) > This is a followup of bug 72162 - Move setVisibleRect() calls into calculateDrawTransformAndVisibility(). > setVisibleRect() calls for mask and replica layers are still in CCLayerTreeHost.cpp but they seem also belong to calculateDrawTransformAndVisibility(). > > Also some questions (copied from my comments to the patch of bug 72162 after it has been committed): > 1. Why setVisibleLayerRect to the whole content bounds of the renderSurfaceLayer instead of the actual visible rect? This sounds like an oversight. I can't think of why it would need to be this way. > 2. setVisibleLayerRect() for the replica layer seems lost after the patch. This sounds like it could be a bug.
Xianzhu Wang
Comment 2 2012-10-18 17:03:35 PDT
The bug has been fixed in chromium.
Note You need to log in before you can comment on or make changes to this bug.