Bug 75715 - [Chromium] Crash when using per-tile painting on Windows.
Summary: [Chromium] Crash when using per-tile painting on Windows.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks: 77897
  Show dependency treegraph
 
Reported: 2012-01-06 10:48 PST by David Reveman
Modified: 2012-02-07 15:30 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.05 KB, patch)
2012-02-03 18:37 PST, David Reveman
no flags Details | Formatted Diff | Diff
Patch (4.38 KB, patch)
2012-02-06 13:00 PST, David Reveman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2012-01-06 10:48:44 PST
More details here: http://code.google.com/p/chromium/issues/detail?id=107461
Comment 1 David Reveman 2012-01-06 10:51:18 PST
Temporary patch to avoid the crash until this issue is solved: https://bugs.webkit.org/show_bug.cgi?id=75705
Comment 2 David Reveman 2012-02-03 18:37:45 PST
Created attachment 125459 [details]
Patch
Comment 3 James Robinson 2012-02-03 19:33:47 PST
I thought there was work underway in Skia to avoid needing a GDI-backed canvas at all on windows for the SkPicture playback path.  What's the status of that?
Comment 4 David Reveman 2012-02-03 19:55:33 PST
(In reply to comment #3)
> I thought there was work underway in Skia to avoid needing a GDI-backed canvas at all on windows for the SkPicture playback path.  What's the status of that?

I'm not aware of that but that would be great!

Can we land this patch for now to fix the crash? I'm happy to implement non GDI-backed canvas use if possible in a separate patch.
Comment 5 David Reveman 2012-02-06 13:00:05 PST
Created attachment 125696 [details]
Patch
Comment 6 David Reveman 2012-02-06 13:08:45 PST
New patch avoids the PlatformCanvas API completely and this seem to be working fine.
Comment 7 James Robinson 2012-02-06 13:09:05 PST
Comment on attachment 125696 [details]
Patch

R=me
Comment 8 WebKit Review Bot 2012-02-07 15:30:13 PST
Comment on attachment 125696 [details]
Patch

Clearing flags on attachment: 125696

Committed r106997: <http://trac.webkit.org/changeset/106997>
Comment 9 WebKit Review Bot 2012-02-07 15:30:18 PST
All reviewed patches have been landed.  Closing bug.