RESOLVED DUPLICATE of bug 75049 75701
EntryBase::toURL produces wrong URL if path contains special characters 
https://bugs.webkit.org/show_bug.cgi?id=75701
Summary EntryBase::toURL produces wrong URL if path contains special characters
Sergey Ryazanov
Reported 2012-01-06 06:04:35 PST
If file name of path contains '#' or '%xx' they get to the URL unescaped. Such an URL doesn't work in XMLHttpRequest or as source of IMG element. String EntryBase::toURL() has its own code what duplicated AsyncFileSystemChromium::virtualPathToFileSystemURL.
Attachments
Patch (8.32 KB, patch)
2012-01-07 04:35 PST, Sergey Ryazanov 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergey Ryazanov
Comment 1 2012-01-07 04:35:24 PST
Created attachment 121548 [details] Patch
Eric U.
Comment 2 2012-01-09 11:12:16 PST
Comment on attachment 121548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121548&action=review > Source/WebCore/fileapi/EntryBase.cpp:59 > + return m_fileSystem->toURL(this); While this makes the code here smaller, it forces all implementers to basically write the same code. All that's really missing here is proper escaping of the path. See https://bugs.webkit.org/show_bug.cgi?id=75049 for the soon-to-be-checked-in fix.
Eric Seidel (no email)
Comment 3 2012-04-19 15:20:25 PDT
Comment on attachment 121548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121548&action=review ericu seems to be tryign to r- this. :) I'll help him. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This will fail teh commit-queue.
Sergey Ryazanov
Comment 4 2012-04-20 05:02:19 PDT
*** This bug has been marked as a duplicate of bug 75049 ***
Note You need to log in before you can comment on or make changes to this bug.