Bug 75681 - [EFL] Fixed displaying buffering progress in the media control.
Summary: [EFL] Fixed displaying buffering progress in the media control.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-05 18:45 PST by KwangYong Choi
Modified: 2012-08-14 03:13 PDT (History)
7 users (show)

See Also:

Attachments
patch (1.37 KB, patch)
2012-07-22 20:07 PDT, KwangYong Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KwangYong Choi 2012-01-05 18:45:33 PST 
Fixed typo. It is required "rangeRect" instead of "rect".
Comment 1 KwangYong Choi 2012-01-05 22:36:18 PST 
It is required "rangeRect" instead of "rect" to display buffering progress properly.
Comment 2 KwangYong Choi 2012-07-22 20:07:28 PDT 
Created attachment 153722 [details]
patch
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-07-22 21:00:02 PDT 
Comment on attachment 153722 [details]
patch

Does it make any existing test pass?
Comment 4 Chris Dumez 2012-07-22 22:26:41 PDT 
Comment on attachment 153722 [details]
patch

Change looks good but it is likely that some tests need rebasing with this fix. It would be good to do the rebasing in the same patch if it is really needed.
Comment 5 KwangYong Choi 2012-07-24 03:39:15 PDT 
I tested "LayoutTests/media/" with/without this patch. But, the test results are same. Each case has 356 failures.

This patch does not affects the test results. It's about network load and displaying media control. The buffering progress can be read from JS properly, but display is wrong.

I think this patch is required to display buffering progress on media control properly.
Comment 6 KwangYong Choi 2012-07-27 04:19:19 PDT 
Should I provide test for this patch? I think it's not easy. :(
Comment 7 Gyuyoung Kim 2012-07-27 10:06:24 PDT 
Comment on attachment 153722 [details]
patch

Could you check if there is difference result on whole layout test. If there is no effect EFL layout test result, looks fine.
Comment 8 Raphael Kubo da Costa (:rakuco) 2012-07-27 17:08:09 PDT 
Are you sure no test can be unskipped after this fix?
Comment 9 KwangYong Choi 2012-07-31 00:11:44 PDT 
My previous test result was wrong. I should use SHARED_CORE But I did't. So I tested it again.

1. LayoutTests/media/ Test after remove efl/Skipped and wk2/Skipped

The results are same. 102 are diff and 1 is flaky.

2. Entire test

The results are little bit different. But the different items are not related to media. The changes on this patch is just display rect on media control. So it does not affect to other part.
Comment 10 KwangYong Choi 2012-08-10 03:32:26 PDT 
There are no changes in LayoutTests. But it's too hard to make a test for this.

If this patch is not applied, then above block to calculate rangeRect is not necessary. I think it need to be merged.
Comment 11 Gyuyoung Kim 2012-08-12 22:34:54 PDT 
Comment on attachment 153722 [details]
patch

If this patch doesn't influence on existing layout test result and there is no unskipped tests, looks good to me.
Comment 12 WebKit Review Bot 2012-08-14 03:13:25 PDT 
Comment on attachment 153722 [details]
patch

Clearing flags on attachment: 153722

Committed r125536: <http://trac.webkit.org/changeset/125536>
Comment 13 WebKit Review Bot 2012-08-14 03:13:30 PDT 
All reviewed patches have been landed.  Closing bug.