Bug 75680 - [chromium] Draw debug tile borders on composited layers
Summary: [chromium] Draw debug tile borders on composited layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-05 18:11 PST by Adrienne Walker
Modified: 2012-01-10 10:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.72 KB, patch)
2012-01-06 10:09 PST, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Use debug border color for tiles (11.26 KB, patch)
2012-01-09 15:15 PST, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-01-05 18:11:35 PST 
[chromium] Draw debug tile borders on composited layers
Comment 1 Adrienne Walker 2012-01-06 10:09:47 PST 
Created attachment 121445 [details]
Patch
Comment 2 Vangelis Kokkevis 2012-01-06 16:53:21 PST 
Comment on attachment 121445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121445&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:43
> +static const Color debugTileBorderColor(0, 0, 200, 100);

nit: would it be possible to use the same color as the debug border for the entire tile?  It may make it easier to distinguish which layer tiles belong to.
Comment 3 Adrienne Walker 2012-01-06 17:37:37 PST 
Comment on attachment 121445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121445&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:43
>> +static const Color debugTileBorderColor(0, 0, 200, 100);
> 
> nit: would it be possible to use the same color as the debug border for the entire tile?  It may make it easier to distinguish which layer tiles belong to.

Unless I'm missing something, all debug borders for tiled layers are the same color, so I don't know that it would help distinguish layers.  I could just make it share the same color, but use a fixed width and alpha value, if you'd like.
Comment 4 Vangelis Kokkevis 2012-01-08 22:20:25 PST 
(In reply to comment #3)
> (From update of attachment 121445 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121445&action=review
> 
> >> Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:43
> >> +static const Color debugTileBorderColor(0, 0, 200, 100);
> > 
> > nit: would it be possible to use the same color as the debug border for the entire tile?  It may make it easier to distinguish which layer tiles belong to.
> 
> Unless I'm missing something, all debug borders for tiled layers are the same color, so I don't know that it would help distinguish layers.  I could just make it share the same color, but use a fixed width and alpha value, if you'd like.

Ah, you're right. All content web layers do share the same color. But maybe future uses of the compositor will try to differentiate between layers.  Seems more consistent to keep the same color for the border and tiles. But still just a nit.
Comment 5 Adrienne Walker 2012-01-09 15:15:15 PST 
Created attachment 121730 [details]
Use debug border color for tiles
Comment 6 Vangelis Kokkevis 2012-01-09 18:30:40 PST 
Comment on attachment 121730 [details]
Use debug border color for tiles

(unofficial) r+ from me.
Comment 7 James Robinson 2012-01-09 18:41:13 PST 
Comment on attachment 121730 [details]
Use debug border color for tiles

R=me
Comment 8 WebKit Review Bot 2012-01-10 10:59:31 PST 
Comment on attachment 121730 [details]
Use debug border color for tiles

Clearing flags on attachment: 121730

Committed r104600: <http://trac.webkit.org/changeset/104600>
Comment 9 WebKit Review Bot 2012-01-10 10:59:36 PST 
All reviewed patches have been landed.  Closing bug.