Bug 75680 – [chromium] Draw debug tile borders on composited layers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrienne Walker]

[chromium] Draw debug tile borders on composited layers

[Adrienne Walker]

Created attachment 121445 [details]
Patch

[Vangelis Kokkevis]

Comment on attachment 121445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121445&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:43
> +static const Color debugTileBorderColor(0, 0, 200, 100);

nit: would it be possible to use the same color as the debug border for the entire tile?  It may make it easier to distinguish which layer tiles belong to.

[Adrienne Walker]

Comment on attachment 121445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121445&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:43
>> +static const Color debugTileBorderColor(0, 0, 200, 100);
> 
> nit: would it be possible to use the same color as the debug border for the entire tile?  It may make it easier to distinguish which layer tiles belong to.

Unless I'm missing something, all debug borders for tiled layers are the same color, so I don't know that it would help distinguish layers.  I could just make it share the same color, but use a fixed width and alpha value, if you'd like.

[Vangelis Kokkevis]

(In reply to comment #3)
> (From update of attachment 121445 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121445&action=review
> 
> >> Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:43
> >> +static const Color debugTileBorderColor(0, 0, 200, 100);
> > 
> > nit: would it be possible to use the same color as the debug border for the entire tile?  It may make it easier to distinguish which layer tiles belong to.
> 
> Unless I'm missing something, all debug borders for tiled layers are the same color, so I don't know that it would help distinguish layers.  I could just make it share the same color, but use a fixed width and alpha value, if you'd like.

Ah, you're right. All content web layers do share the same color. But maybe future uses of the compositor will try to differentiate between layers.  Seems more consistent to keep the same color for the border and tiles. But still just a nit.

[Adrienne Walker]

Created attachment 121730 [details]
Use debug border color for tiles

[Vangelis Kokkevis]

Comment on attachment 121730 [details]
Use debug border color for tiles

(unofficial) r+ from me.

[James Robinson]

Comment on attachment 121730 [details]
Use debug border color for tiles

R=me

[WebKit Review Bot]

Comment on attachment 121730 [details]
Use debug border color for tiles

Clearing flags on attachment: 121730

Committed r104600: <http://trac.webkit.org/changeset/104600>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.