WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
75663
Move Cookie.h into namespace Platform
https://bugs.webkit.org/show_bug.cgi?id=75663
Summary
Move Cookie.h into namespace Platform
Adam Barth
Reported
2012-01-05 15:37:10 PST
Move Cookie.h into namespace Platform
Attachments
Patch
(4.97 KB, patch)
2012-01-05 15:37 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-01-05 15:37:43 PST
Created
attachment 121351
[details]
Patch
James Robinson
Comment 2
2012-01-05 15:45:56 PST
Comment on
attachment 121351
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=121351&action=review
> Source/WebCore/platform/Cookie.h:86 > +using Platform::Cookie; > +using Platform::CookieHash;
can we just update people using this to the new namespace as we migrate types? i'm really concerned about collisions if we end up putting every type in WebCore/platform into the global namespace
Eric Seidel (no email)
Comment 3
2012-01-05 15:46:12 PST
Comment on
attachment 121351
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=121351&action=review
> Source/WebCore/platform/chromium/PlatformSupport.h:38 > +#include "Cookie.h"
Why include instead of just forward declare in the right namespace?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug