Bug 75663 - Move Cookie.h into namespace Platform
Summary: Move Cookie.h into namespace Platform
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 75664
  Show dependency tree / graph
 
Reported: 2012-01-05 15:37 PST by Adam Barth
Modified: 2012-01-05 16:10 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2012-01-05 15:37 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-01-05 15:37:10 PST 
Move Cookie.h into namespace Platform
Comment 1 Adam Barth 2012-01-05 15:37:43 PST 
Created attachment 121351 [details]
Patch
Comment 2 James Robinson 2012-01-05 15:45:56 PST 
Comment on attachment 121351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121351&action=review

> Source/WebCore/platform/Cookie.h:86
> +using Platform::Cookie;
> +using Platform::CookieHash;

can we just update people using this to the new namespace as we migrate types? i'm really concerned about collisions if we end up putting every type in WebCore/platform into the global namespace
Comment 3 Eric Seidel (no email) 2012-01-05 15:46:12 PST 
Comment on attachment 121351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121351&action=review

> Source/WebCore/platform/chromium/PlatformSupport.h:38
> +#include "Cookie.h"

Why include instead of just forward declare in the right namespace?