Bug 75662 - Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
Summary: Pixel results from DumpRenderTree and WebKitTestRunner don't match because of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 72424 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-05 15:37 PST by Simon Fraser (smfr)
Modified: 2012-01-08 12:15 PST (History)
6 users (show)

See Also:

Attachments
Patch (12.96 KB, patch)
2012-01-05 15:42 PST, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-01-05 15:37:10 PST 
Pixel results from DumpRenderTree and WebKitTestRunner don't match, suffer colorspace issues
Comment 1 Simon Fraser (smfr) 2012-01-05 15:42:02 PST 
Created attachment 121354 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-01-05 15:42:35 PST 
<rdar://problem/10640723>
Comment 3 Alexey Proskuryakov 2012-01-05 23:06:58 PST 
Comment on attachment 121354 [details]
Patch

How is this related to bug 72424?
Comment 4 Simon Fraser (smfr) 2012-01-06 09:20:26 PST 
The patch here fixes bug 72424 too.
Comment 5 Simon Fraser (smfr) 2012-01-06 09:20:30 PST 
*** Bug 72424 has been marked as a duplicate of this bug. ***
Comment 6 mitz 2012-01-06 13:56:30 PST 
Comment on attachment 121354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121354&action=review

> Tools/ChangeLog:3
> +        Pixel results from DumpRenderTree and WebKitTestRunner don't match, suffer colorspace issues

I think it’s us who suffer. The pixel results are secretly enjoying it.

> Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:55
> +    // Creating this bitmap in the device color space should prevent any color conversion when the image of the web view is drawn into it.

Can you say “prevents” instead of “should prevent”? Does it not really do what it should do?
Comment 7 Simon Fraser (smfr) 2012-01-06 15:35:23 PST 
http://trac.webkit.org/changeset/104351
Comment 8 Darin Adler 2012-01-08 12:15:25 PST 
Wow, what a great thing to do! Wish we had done this years ago.