Bug 75643 – WK2: Safari fails to open a PostScript file in Preview from context menu

• Status: RESOLVED
• Resolution: FIXED
• Component: PDF

[Alexey Proskuryakov]

Steps to Reproduce:
1. Load this URL into Safari:  http://www.cerc.utexas.edu/~vinod/pubs/ultrascalar-arvlsi-99.ps
2. Right-click on the document and select "Open with Preview.app".
3. Observe that this fails.

<rdar://problem/9823430>

[Alexey Proskuryakov]

Created attachment 121312 [details]
proposed fix

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r104198>.

[Darin Adler]

Comment on attachment 121312 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=121312&action=review

> Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:455
> +        m_suggestedFilename = String(suggestedFilename + ".pdf");

I don’t think the String() is needed here.

[Alexey Proskuryakov]

> > Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:455
> > +        m_suggestedFilename = String(suggestedFilename + ".pdf");
> 
> I don’t think the String() is needed here.

It didn't build otherwise. A result of adding two Strings is a class that can only be converted to String, not NSString. Maybe we should teach it to support NSString.

[Darin Adler]

(In reply to comment #4)
> > > Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:455
> > > +        m_suggestedFilename = String(suggestedFilename + ".pdf");
> > 
> > I don’t think the String() is needed here.
> 
> It didn't build otherwise. A result of adding two Strings is a class that can only be converted to String, not NSString. Maybe we should teach it to support NSString.

I see. Didn’t realize that m_suggestedFilename was an NSString.