Bug 75633 – REGRESSION (r104060): Layout Test fast/media/viewport-media-query.html is occasionally failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dmitry Lomov]

The following layout test is failing on chromium

fast/media/viewport-media-query.html

Probable cause:

http://trac.webkit.org/changeset/104060/

[Dmitry Lomov]

Skipped in chromium: http://trac.webkit.org/changeset/104182

[Antti Koivisto]

I can't repro on OSX and code inspection didn't reveal why this would be happening. Is this easy to repro on Chromium?

[Antti Koivisto]

*** Bug 75772 has been marked as a duplicate of this bug. ***

[Antti Koivisto]

Created attachment 121554 [details]
patch, with a reliable test case

[Ryosuke Niwa]

Comment on attachment 121554 [details]
patch, with a reliable test case

View in context: https://bugs.webkit.org/attachment.cgi?id=121554&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=75633
> +        Layout Test fast/media/viewport-media-query.html is occasionally failing

Bug summary should appear before the bug url.

> Source/WebCore/ChangeLog:10
> +        - Reset style selector on documentElement change.
> +        - Remove the code for lazy documentElement initialization. It is not an useful optimization,
> +          the children of Document rarely change.

Could you also explain what was causing the occasional failure of viewport-media-query.html?

> LayoutTests/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=75633
> +        Layout Test fast/media/viewport-media-query.html is occasionally failing

Ditto about the order.

[Andreas Kling]

Comment on attachment 121554 [details]
patch, with a reliable test case

r=me with a bit more pizzazz in the ChangeLog.

[Antti Koivisto]

http://trac.webkit.org/changeset/104399

[Antti Koivisto]

I can't repro the failure in fast/media/viewport-media-query.html but I think this is the same issue.