Bug 75627 - make canvas-lineWidth test pass even if pixel values vary a tiny bit
Summary: make canvas-lineWidth test pass even if pixel values vary a tiny bit
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: epoger
Depends on:
Reported: 2012-01-05 09:11 PST by epoger
Modified: 2012-01-06 07:43 PST (History)
7 users (show)

See Also:

Patch (1.99 KB, patch)
2012-01-05 09:15 PST, epoger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2012-01-05 09:11:59 PST
In https://bugs.webkit.org/show_bug.cgi?id=75552 ('rebaselining some canvas images'), we noted that this test was reporting failure even though the results were "close enough".  So I have modified the test to pass, as long as the results are indeed "close enough".
Comment 1 epoger 2012-01-05 09:15:00 PST
Created attachment 121287 [details]
Comment 2 epoger 2012-01-05 09:20:51 PST
Tom and Ryosuke- please look at the test change and see if it looks reasonable to you.

If so, Ryosuke, please r+.
Comment 3 Tom Hudson 2012-01-05 09:29:22 PST
LGTM. Allowable difference may grow in the future, but we don't have a quantified range, so let's start conservative.
Comment 4 epoger 2012-01-05 13:11:09 PST
rniwa has added a few more people in CC, since he isn't very familiar with canvas stuff...
Comment 5 epoger 2012-01-05 13:13:54 PST
Stephen- could you plese take a look, and r+ if appropriate?
Comment 6 Brent Fulgham 2012-01-05 13:19:50 PST
LGTM. I am strongly in favor of this change, as the WinCairo port often has small differences against the Apple Windows port. This would greatly reduce the amount of custom testing needed to stay in sync.
Comment 7 Stephen White 2012-01-05 13:22:04 PST
I'm ok with this, as long as it's spec-compliant.  r=me
Comment 8 WebKit Review Bot 2012-01-06 07:43:13 PST
Comment on attachment 121287 [details]

Clearing flags on attachment: 121287

Committed r104293: <http://trac.webkit.org/changeset/104293>
Comment 9 WebKit Review Bot 2012-01-06 07:43:17 PST
All reviewed patches have been landed.  Closing bug.