WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75619
Improve SelectorChecker::determineSelectorScopes
https://bugs.webkit.org/show_bug.cgi?id=75619
Summary
Improve SelectorChecker::determineSelectorScopes
Antti Koivisto
Reported
2012-01-05 06:06:50 PST
SelectorChecker::determineSelectorScopes currently searches to the end of the selector chain and then sees if the last one is suitable to be a scope. A better algorithm will find a scope from anywhere in the chain.
Attachments
patch
(3.46 KB, patch)
2012-01-05 06:12 PST
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2012-01-05 06:12:35 PST
Created
attachment 121268
[details]
patch
Andreas Kling
Comment 2
2012-01-05 06:31:15 PST
Comment on
attachment 121268
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=121268&action=review
> Source/WebCore/ChangeLog:14 > +
Needs more marketing!
> Source/WebCore/css/SelectorChecker.cpp:1405 > + // This picks the widest scope, not the narrowest, to minimize the number of found scoped.
Typo, scopes.
Antti Koivisto
Comment 3
2012-01-05 06:41:38 PST
http://trac.webkit.org/changeset/104152
, with improved marketing
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug