Bug 75612 - WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
Summary: WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-05 02:35 PST by Hajime Morrita
Modified: 2012-01-06 00:04 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2012-01-05 02:39 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-01-05 02:35:59 PST 
Inline methods cannot have any visible linkages. Thus they shouldn't be marked as WTF_EXPORT_PRIVATE.
This is a series of nit-picking for making Bug 72855 build-able.
Comment 1 Hajime Morrita 2012-01-05 02:39:51 PST 
Created attachment 121247 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-01-05 09:27:57 PST 
FWIW, this was added in bug 27551, which looks like an original of bug 72855.
Comment 3 Hajime Morrita 2012-01-05 23:43:03 PST 
(In reply to comment #2)
> FWIW, this was added in bug 27551, which looks like an original of bug 72855.
Alexey, thanks for checking this!

Actually this is why we are switching from hand-crafted annotation to automated annotation.
With a tool's help, the annotation can be more precise. 
This bug was also found during the investigation to see why generated annotations wasn't built.
Comment 4 WebKit Review Bot 2012-01-06 00:04:43 PST 
Comment on attachment 121247 [details]
Patch

Clearing flags on attachment: 121247

Committed r104270: <http://trac.webkit.org/changeset/104270>
Comment 5 WebKit Review Bot 2012-01-06 00:04:48 PST 
All reviewed patches have been landed.  Closing bug.