Bug 75611 - [BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame
Summary: [BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-05 01:22 PST by Leo Yang
Modified: 2012-01-08 18:51 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.96 KB, patch)
2012-01-05 01:28 PST, Leo Yang
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-01-05 01:22:55 PST
In platform/network/blackberry/ResourceHandleBlackBerry.cpp, We were using NetworkingContext::wrappedFrame() to access frame associated with the networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry porting internally. We don't want to upstream this specific change, so use the concrete FrameNetworkingContextBlackBerry to avoid modifying platform/network/NetworkingContext.h.
Comment 1 Leo Yang 2012-01-05 01:28:45 PST
Created attachment 121240 [details]
Patch
Comment 2 Antonio Gomes 2012-01-06 13:36:48 PST
Comment on attachment 121240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121240&action=review

> Source/WebCore/ChangeLog:11
> +        networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry
> +        porting internally. We don't want to upstream this specific change, so use

You could mention why it was added and why it is not needed or it is fine to use the "concrete" one?
Comment 3 Leo Yang 2012-01-08 18:35:18 PST
(In reply to comment #2)
> (From update of attachment 121240 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121240&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry
> > +        porting internally. We don't want to upstream this specific change, so use
> 
> You could mention why it was added and why it is not needed or it is fine to use the "concrete" one?

Thanks. Will add before landing.
Comment 4 Leo Yang 2012-01-08 18:51:03 PST
Committed r104427: <http://trac.webkit.org/changeset/104427>