Bug 75611 – [BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Leo Yang]

In platform/network/blackberry/ResourceHandleBlackBerry.cpp, We were using NetworkingContext::wrappedFrame() to access frame associated with the networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry porting internally. We don't want to upstream this specific change, so use the concrete FrameNetworkingContextBlackBerry to avoid modifying platform/network/NetworkingContext.h.

[Leo Yang]

Created attachment 121240 [details]
Patch

[Antonio Gomes]

Comment on attachment 121240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121240&action=review

> Source/WebCore/ChangeLog:11
> +        networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry
> +        porting internally. We don't want to upstream this specific change, so use

You could mention why it was added and why it is not needed or it is fine to use the "concrete" one?

[Leo Yang]

(In reply to comment #2)
> (From update of attachment 121240 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121240&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        networking context. NetworkingContext::wrappedFrame() was added by the BlackBerry
> > +        porting internally. We don't want to upstream this specific change, so use
> 
> You could mention why it was added and why it is not needed or it is fine to use the "concrete" one?

Thanks. Will add before landing.

[Leo Yang]

Committed r104427: <http://trac.webkit.org/changeset/104427>