Bug 75604 - All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments
Summary: All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2012-01-04 23:22 PST by Mark Rowe (bdash)
Modified: 2012-01-04 23:39 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (2.93 KB, patch)
2012-01-04 23:26 PST, Mark Rowe (bdash) 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2012-01-04 23:22:02 PST 
JSC::Arguments has an OwnPtr<ArgumentsData> as a member but the destructor is never invoked due to Arguments being a JSCell subclass. This means that the ArgumentsData instances are never deallocated.
Comment 1 Mark Rowe (bdash) 2012-01-04 23:26:32 PST 
Created attachment 121221 [details]
Patch v1

From my reading of the code, this looks like the correct fix. Testing shows that the leaks go away. I'm taking that as a positive sign!
Comment 2 Filip Pizlo 2012-01-04 23:28:46 PST 
Comment on attachment 121221 [details]
Patch v1

I concur.  Looks good.
Comment 3 Filip Pizlo 2012-01-04 23:29:38 PST 
<rdar://problem/10647206>
Comment 4 Mark Rowe (bdash) 2012-01-04 23:39:58 PST 
Fixed in r104119.