WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75604
All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments
https://bugs.webkit.org/show_bug.cgi?id=75604
Summary
All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments
Mark Rowe (bdash)
Reported
2012-01-04 23:22:02 PST
JSC::Arguments has an OwnPtr<ArgumentsData> as a member but the destructor is never invoked due to Arguments being a JSCell subclass. This means that the ArgumentsData instances are never deallocated.
Attachments
Patch v1
(2.93 KB, patch)
2012-01-04 23:26 PST
,
Mark Rowe (bdash)
fpizlo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2012-01-04 23:26:32 PST
Created
attachment 121221
[details]
Patch v1 From my reading of the code, this looks like the correct fix. Testing shows that the leaks go away. I'm taking that as a positive sign!
Filip Pizlo
Comment 2
2012-01-04 23:28:46 PST
Comment on
attachment 121221
[details]
Patch v1 I concur. Looks good.
Filip Pizlo
Comment 3
2012-01-04 23:29:38 PST
<
rdar://problem/10647206
>
Mark Rowe (bdash)
Comment 4
2012-01-04 23:39:58 PST
Fixed in
r104119
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug