Bug 75603 - InspectorStyleSheet: Avoid cloning CSSRuleLists.
Summary: InspectorStyleSheet: Avoid cloning CSSRuleLists.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2012-01-04 22:45 PST by Andreas Kling
Modified: 2012-01-05 02:20 PST (History)
3 users (show)

See Also:

Patch (1.96 KB, patch)
2012-01-04 22:49 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-01-04 22:45:23 PST
InspectorStyleSheet currently uses CSSRuleList::create(styleSheet, omitCharsetRules = true), and the omitCharsetRules forces the CSSRuleList constructor to clone the stylesheet's rule list.

All rules other than style-rules and rules with internal rule lists are discarded by InspectorStyleSheet anyway, so we don't need to filter out charset rules beforehand.
Comment 1 Andreas Kling 2012-01-04 22:49:19 PST
Created attachment 121219 [details]
Comment 2 Ryosuke Niwa 2012-01-04 22:55:56 PST
Comment on attachment 121219 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=121219&action=review

> Source/WebCore/ChangeLog:16
> +            Don't pass omitCharsetRules=true to the CSSRuleList constructor.

Don't think we normally indent here.
Comment 3 Andreas Kling 2012-01-05 02:20:28 PST
Comment on attachment 121219 [details]

Clearing flags on attachment: 121219

Committed r104131: <http://trac.webkit.org/changeset/104131>
Comment 4 Andreas Kling 2012-01-05 02:20:37 PST
All reviewed patches have been landed.  Closing bug.