Bug 75599 - Remove passing media/media-blocked-by-beforeload.html from test_expectations.txt
Summary: Remove passing media/media-blocked-by-beforeload.html from test_expectations.txt
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shadi
URL:
Keywords:
Depends on: 63558 68536
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-04 18:56 PST by Shadi
Modified: 2012-01-13 15:55 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2012-01-04 18:57 PST, Shadi
eric.carlson: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shadi 2012-01-04 18:56:09 PST
Remove passing media/media-blocked-by-beforeload.html from test_expectations.txt
Comment 1 Shadi 2012-01-04 18:57:56 PST
Created attachment 121204 [details]
Patch

Test is not flaky, remove bug from expectation.
Comment 2 WebKit Review Bot 2012-01-06 15:29:50 PST
Comment on attachment 121204 [details]
Patch

Rejecting attachment 121204 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/gtk/test_expectations.txt
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/11173132
Comment 3 Shadi 2012-01-09 09:51:59 PST
Comment on attachment 121204 [details]
Patch

Eric, can you please try to commit again?
Comment 4 WebKit Review Bot 2012-01-09 09:52:34 PST
Comment on attachment 121204 [details]
Patch

Rejecting attachment 121204 [details] from commit-queue.

shadi@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Review Bot 2012-01-09 11:12:55 PST
Comment on attachment 121204 [details]
Patch

Rejecting attachment 121204 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/gtk/test_expectations.txt
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/11188544
Comment 6 Shadi 2012-01-10 10:41:42 PST
Is that a problem with the commit bot?
Comment 7 Shadi 2012-01-13 15:43:48 PST
Eric, sorry for bothering but can you please try to commit again please? :)

Thanks.
Comment 8 WebKit Review Bot 2012-01-13 15:55:18 PST
Comment on attachment 121204 [details]
Patch

Rejecting attachment 121204 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/gtk/test_expectations.txt
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/11152762