RESOLVED FIXED 75590
webkitpy: clean up port factory methods 
https://bugs.webkit.org/show_bug.cgi?id=75590
Summary webkitpy: clean up port factory methods
Dirk Pranke
Reported 2012-01-04 17:49:28 PST
webkitpy: clean up port factory methods
Attachments
Patch (20.45 KB, patch)
2012-01-04 17:57 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix 'chromium-gpu' as a port name, add tests (22.25 KB, patch)
2012-01-05 12:43 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-01-04 17:57:15 PST
Created attachment 121194 [details] Patch
Eric Seidel (no email)
Comment 2 2012-01-04 18:09:40 PST
Comment on attachment 121194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121194&action=review Seems sane. Thanks! > Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py:-108 > - # The actual Chrome class names aren't available so we test that the > - # objects we get are at least subclasses of the Chromium versions. This is some legacy from the days of the split repo?
Dirk Pranke
Comment 3 2012-01-04 20:05:43 PST
Comment on attachment 121194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121194&action=review >> Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py:-108 >> - # objects we get are at least subclasses of the Chromium versions. > > This is some legacy from the days of the split repo? No, it was the result of having the classes declared inside the google_chrome.get() factory method and hence lexically hidden.
WebKit Review Bot
Comment 4 2012-01-05 07:01:27 PST
Comment on attachment 121194 [details] Patch Clearing flags on attachment: 121194 Committed r104159: <http://trac.webkit.org/changeset/104159>
WebKit Review Bot
Comment 5 2012-01-05 07:01:31 PST
All reviewed patches have been landed. Closing bug.
Hin-Chung Lam
Comment 6 2012-01-05 08:40:09 PST
Reverted r104159 for reason: Chromium port GPU tests cannot be executed. Committed r104166: <http://trac.webkit.org/changeset/104166>
Dirk Pranke
Comment 7 2012-01-05 12:43:08 PST
Created attachment 121313 [details] fix 'chromium-gpu' as a port name, add tests
Eric Seidel (no email)
Comment 8 2012-01-05 12:43:48 PST
Comment on attachment 121313 [details] fix 'chromium-gpu' as a port name, add tests OK.
Dirk Pranke
Comment 9 2012-01-05 12:45:27 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=121313&action=review > Tools/Scripts/webkitpy/layout_tests/port/factory.py:103 > + port_name = port_to_use Note the reassignment of port_name here and following ... this was dropped in the first patch, which meant that ChromiumLinuxPort would get handed 'chromium-gpu' and not something containing a 'linux' string, so the version detection broke. > Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py:118 > + def test_chromium_gpu(self): Newly added tests to catch that case.
WebKit Review Bot
Comment 10 2012-01-05 15:07:50 PST
Comment on attachment 121313 [details] fix 'chromium-gpu' as a port name, add tests Clearing flags on attachment: 121313 Committed r104230: <http://trac.webkit.org/changeset/104230>
WebKit Review Bot
Comment 11 2012-01-05 15:07:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.