Bug 75557 – [chromium] Create unit tests for CCTiledLayerImpl

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrienne Walker]

[chromium] Create unit tests for CCTiledLayerImpl

[Adrienne Walker]

Created attachment 121120 [details]
Patch

[James Robinson]

Comment on attachment 121120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121120&action=review

Awesome! R=me

> Source/WebKit/chromium/tests/CCTiledLayerImplTest.cpp:38
> +#define QUAD(i) "    Quad: " << i

can you move this down closer to the first use?

do we really really need this? we have a lot of quad-named things going on. what about a string constant that's <<'d in like normal?

> Source/WebKit/chromium/tests/CCTiledLayerImplTest.cpp:246
> +        EXPECT_EQ(quads[i]->material(), CCDrawQuad::TiledContent) << QUAD(i);

think this should be ASSERT_EQ() or the next few lines will do really crazy and potentially hard-to-diagnose things

[Adrienne Walker]

Comment on attachment 121120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121120&action=review

>> Source/WebKit/chromium/tests/CCTiledLayerImplTest.cpp:38
>> +#define QUAD(i) "    Quad: " << i
> 
> can you move this down closer to the first use?
> 
> do we really really need this? we have a lot of quad-named things going on. what about a string constant that's <<'d in like normal?

Sure.  I'll make it a string constant.

>> Source/WebKit/chromium/tests/CCTiledLayerImplTest.cpp:246
>> +        EXPECT_EQ(quads[i]->material(), CCDrawQuad::TiledContent) << QUAD(i);
> 
> think this should be ASSERT_EQ() or the next few lines will do really crazy and potentially hard-to-diagnose things

Good point.  Will change to an assert.

[Adrienne Walker]

Committed r104052: <http://trac.webkit.org/changeset/104052>

[Adrienne Walker]

Reopening, due to OwnPtr copy constructor failure.  :(

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder%20%28dbg%29/builds/18038/steps/compile/logs/stdio

[Adrienne Walker]

Created attachment 121295 [details]
Fix win build errors

[Adrienne Walker]

(In reply to comment #6)
> Created an attachment (id=121295) [details]
> Fix win build errors

^ Just uploading this for posterity.  No review needed.

[Adrienne Walker]

Committed r104176: <http://trac.webkit.org/changeset/104176>