Bug 75547 - [chromium] Use scratch textures in skia/Ganesh for canvas backing stores.
Summary: [chromium] Use scratch textures in skia/Ganesh for canvas backing stores.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-04 07:40 PST by Stephen White
Modified: 2013-04-09 13:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.97 KB, patch)
2012-01-04 07:54 PST, Stephen White 		senorblanco: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-01-04 07:40:43 PST 
This improves performance when canvas backing stores are re-created at the same res, since Ganesh will retrieve them from cache rather than performing a glTexImage2D().
Comment 1 Stephen White 2012-01-04 07:54:38 PST 
Created attachment 121111 [details]
Patch
Comment 2 Kenneth Russell 2012-01-04 12:05:51 PST 
Comment on attachment 121111 [details]
Patch

Looks good to me as long as it's been tested. You're sure that this code path in Ganesh won't change GL state in a way that might confuse the caller?
Comment 3 Brian Salomon 2012-01-04 12:21:15 PST 
I think we will want to handle the recycling of textures on behalf of the client transparently in skia without changing webkit. This change will work but every canvas will count against the cache budget for skia's internally created textures.
Comment 4 Stephen White 2012-01-04 12:22:22 PST 
Comment on attachment 121111 [details]
Patch

After discussion w/Brian, we'll try this another way.