Bug 75518 - [GTK] [AC] Simplify accelerated compositing build options
Summary: [GTK] [AC] Simplify accelerated compositing build options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 74087
  Show dependency tree / graph
 
Reported: 2012-01-03 20:59 PST by Martin Robinson
Modified: 2012-01-09 07:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.76 KB, patch)
2012-01-03 21:14 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (6.24 KB, patch)
2012-01-06 18:23 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-01-03 20:59:33 PST 
We can eliminate the --enable-3d-rendering option, as right now it aligns exactly with accelerated compositing support. This will also prevent enabling accelerated compositing, but not 3D rendering.
Comment 1 Martin Robinson 2012-01-03 21:14:13 PST 
Created attachment 121054 [details]
Patch
Comment 2 Alejandro G. Castro 2012-01-05 04:44:51 PST 
Comment on attachment 121054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121054&action=review

LGTM, just a clarification.

> Source/WebCore/GNUmakefile.am:556
> +	-DUSE_ACCELERATED_COMPOSITING=1

Shouldn't we use WTF_USE_ ? The cppflags were already defined in the GNUMakefile.am of the base directory, should we remove them there?
Comment 3 Martin Robinson 2012-01-06 18:23:13 PST 
Created attachment 121530 [details]
Patch
Comment 4 Martin Robinson 2012-01-06 18:24:06 PST 
(In reply to comment #3)
> Created an attachment (id=121530) [details]
> Patch

Thanks for the review! Both issues you pointed out were important problems with my first patch. I have tried to correct them in the latest version.
Comment 5 Gustavo Noronha (kov) 2012-01-09 04:37:38 PST 
Comment on attachment 121530 [details]
Patch

+1 =)
Comment 6 WebKit Review Bot 2012-01-09 07:08:58 PST 
Comment on attachment 121530 [details]
Patch

Clearing flags on attachment: 121530

Committed r104459: <http://trac.webkit.org/changeset/104459>
Comment 7 WebKit Review Bot 2012-01-09 07:09:03 PST 
All reviewed patches have been landed.  Closing bug.