Bug 75516 - DFG: The assertion that a double-voted variable cannot become double-unvoted is wrong
Summary: DFG: The assertion that a double-voted variable cannot become double-unvoted ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 20:42 PST by Filip Pizlo
Modified: 2012-01-03 23:27 PST (History)
0 users

See Also:

Attachments
the patch (3.39 KB, patch)
2012-01-03 20:45 PST, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
the patch, with test (14.21 KB, patch)
2012-01-03 21:41 PST, Filip Pizlo 		aestes: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-01-03 20:42:32 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-01-03 20:45:04 PST 
Created attachment 121048 [details]
the patch

I'm going to try to reduce a test case for this, though this may be hard.
Comment 2 Filip Pizlo 2012-01-03 21:41:53 PST 
Created attachment 121059 [details]
the patch, with test

Test needs review.
Comment 3 Andy Estes 2012-01-03 21:45:02 PST 
Comment on attachment 121059 [details]
the patch, with test

View in context: https://bugs.webkit.org/attachment.cgi?id=121059&action=review

> LayoutTests/ChangeLog:3
> +        DFG: The assertion that a double-voted variable cannot becom double-unvoted is wrong

Typo: 'becom'

> LayoutTests/ChangeLog:10
> +        that become either double, or integer, or mix or double and integer only after multiple

Typo: 'or mix or double...'
Comment 4 Filip Pizlo 2012-01-03 21:45:42 PST 
Test rubber stamped by Andy Estes.  Will do a full testing run and then land.
Comment 5 Filip Pizlo 2012-01-03 21:46:12 PST 
(In reply to comment #3)
> (From update of attachment 121059 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121059&action=review
> 
> > LayoutTests/ChangeLog:3
> > +        DFG: The assertion that a double-voted variable cannot becom double-unvoted is wrong
> 
> Typo: 'becom'
> 
> > LayoutTests/ChangeLog:10
> > +        that become either double, or integer, or mix or double and integer only after multiple
> 
> Typo: 'or mix or double...'

Fixed and fixed.  Thanks!
Comment 6 Andy Estes 2012-01-03 21:46:41 PST 
Comment on attachment 121059 [details]
the patch, with test

r=me for the test if you fix the ChangeLog typos. The code change is covered by Gavin's review.
Comment 7 Filip Pizlo 2012-01-03 23:27:40 PST 
Landed in http://trac.webkit.org/changeset/104016