RESOLVED INVALID 75491
Plumbs WebLayerTreeViewImpl::didCompleteSwapBuffers 
https://bugs.webkit.org/show_bug.cgi?id=75491
Summary Plumbs WebLayerTreeViewImpl::didCompleteSwapBuffers
Peter Kotwicz
Reported 2012-01-03 14:00:50 PST
Plubs WebLayerTreeViewImpl::didCompleteSwapBuffers
Attachments
Patch (2.93 KB, patch)
2012-01-03 14:06 PST, Peter Kotwicz 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Kotwicz
Comment 1 2012-01-03 14:06:57 PST
Created attachment 120991 [details] Patch
Peter Kotwicz
Comment 2 2012-01-03 14:09:02 PST
Did not plumb ::didCommitAndDrawFrame as it is not needed yet
Peter Kotwicz
Comment 3 2012-01-03 14:14:25 PST
This is the missing piece for the multithreaded compositor to work with accelerated content. Once webgraphicscontext3d_command_buffer_impl is used in the browser compositor, accelerated content should work with the multithreaded compositor
Antoine Labour
Comment 4 2012-01-03 14:19:42 PST
LGTM, but you'll need the chrome-side change to land first before this can go in.
James Robinson
Comment 5 2012-01-03 14:26:34 PST
Comment on attachment 120991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120991&action=review > Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h:52 > + // Signals that a swap buffers has been completed. > + virtual void didCompleteSwapBuffers() = 0; > + where's the chromium-side implementation of this?
WebKit Review Bot
Comment 6 2012-01-03 15:42:39 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Peter Kotwicz
Comment 7 2012-01-13 07:18:56 PST
Ping. The chromium side has landed. Chromium side: http://codereview.chromium.org/9014030
James Robinson
Comment 8 2012-01-14 10:13:21 PST
The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)
Peter Kotwicz
Comment 9 2012-01-14 15:05:56 PST
James, do you have suggestions for the comment? I am pulling a blank. I am thinking: "Signals that a new color buffer has been posted to the native window."(In reply to comment #8) > The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)
Anders Carlsson
Comment 10 2013-09-01 10:31:08 PDT
Chromium is gone.
Note You need to log in before you can comment on or make changes to this bug.