Plubs WebLayerTreeViewImpl::didCompleteSwapBuffers
Created attachment 120991 [details] Patch
Did not plumb ::didCommitAndDrawFrame as it is not needed yet
This is the missing piece for the multithreaded compositor to work with accelerated content. Once webgraphicscontext3d_command_buffer_impl is used in the browser compositor, accelerated content should work with the multithreaded compositor
LGTM, but you'll need the chrome-side change to land first before this can go in.
Comment on attachment 120991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120991&action=review > Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h:52 > + // Signals that a swap buffers has been completed. > + virtual void didCompleteSwapBuffers() = 0; > + where's the chromium-side implementation of this?
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Ping. The chromium side has landed. Chromium side: http://codereview.chromium.org/9014030
The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)
James, do you have suggestions for the comment? I am pulling a blank. I am thinking: "Signals that a new color buffer has been posted to the native window."(In reply to comment #8) > The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)
Chromium is gone.