Bug 75491 - Plumbs WebLayerTreeViewImpl::didCompleteSwapBuffers
Summary: Plumbs WebLayerTreeViewImpl::didCompleteSwapBuffers
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-01-03 14:00 PST by Peter Kotwicz
Modified: 2013-09-01 10:31 PDT (History)
6 users (show)

See Also:

Patch (2.93 KB, patch)
2012-01-03 14:06 PST, Peter Kotwicz
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kotwicz 2012-01-03 14:00:50 PST
Plubs WebLayerTreeViewImpl::didCompleteSwapBuffers
Comment 1 Peter Kotwicz 2012-01-03 14:06:57 PST
Created attachment 120991 [details]
Comment 2 Peter Kotwicz 2012-01-03 14:09:02 PST
Did not plumb ::didCommitAndDrawFrame as it is not needed yet
Comment 3 Peter Kotwicz 2012-01-03 14:14:25 PST
This is the missing piece for the multithreaded compositor to work with accelerated content. Once webgraphicscontext3d_command_buffer_impl is used in the browser compositor, accelerated content should work with the multithreaded compositor
Comment 4 Antoine Labour 2012-01-03 14:19:42 PST
LGTM, but you'll need the chrome-side change to land first before this can go in.
Comment 5 James Robinson 2012-01-03 14:26:34 PST
Comment on attachment 120991 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=120991&action=review

> Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h:52
> +    // Signals that a swap buffers has been completed.
> +    virtual void didCompleteSwapBuffers() = 0;
> +

where's the chromium-side implementation of this?
Comment 6 WebKit Review Bot 2012-01-03 15:42:39 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 7 Peter Kotwicz 2012-01-13 07:18:56 PST
Ping. The chromium side has landed.
Chromium side:
Comment 8 James Robinson 2012-01-14 10:13:21 PST
The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)
Comment 9 Peter Kotwicz 2012-01-14 15:05:56 PST
James, do you have suggestions for the comment? I am pulling a blank.
I am thinking: "Signals that a new color buffer has been posted to the native window."(In reply to comment #8)
> The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)
Comment 10 Anders Carlsson 2013-09-01 10:31:08 PDT
Chromium is gone.