Bug 75482 – Move HTMLFormControlElementWithState class in its own header file.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexis Menard (darktears)]

Move HTMLFormControlElementWithState class in its own header file.

[Alexis Menard (darktears)]

Created attachment 120970 [details]
Patch

[Kent Tamura]

Comment on attachment 120970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120970&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:14638
> -				7AA51B6D1483B61600AD2752 /* InspectorBaseAgent.cpp */,
>  				7AA51B6C1483B61600AD2752 /* InspectorBaseAgent.h */,
> +				7AA51B6D1483B61600AD2752 /* InspectorBaseAgent.cpp */,

Please do not reorder unrelated files in this patch.
Such patch often makes conflicts as you see on Qt EWS.

[Alexis Menard (darktears)]

Created attachment 121253 [details]
Patch

New version. Sounds like if I upload the patch with webkit-patch it sorts the Xcode file.

[Kent Tamura]

Comment on attachment 121253 [details]
Patch

We need to update html/HTMLElementsAllInOne.cpp.

[Kent Tamura]

Comment on attachment 121253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121253&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:17218
> +				E14F1C3214B5C1CC00EA9009 /* HTMLFormControlElementWithState.cpp */,
> +				E14F1C3314B5C1CC00EA9009 /* HTMLFormControlElementWithState.h */,
>  				49484FAE102CF01E00187DD3 /* canvas */,

Please insert these new lines to sorted position.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:24968
>  				FD537353137B651800008DCE /* ZeroPole.h in Headers */,
> +				E14F1C3514B5C1CC00EA9009 /* HTMLFormControlElementWithState.h in Headers */,

ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:27872
>  				FD537352137B651800008DCE /* ZeroPole.cpp in Sources */,
> +				E14F1C3414B5C1CC00EA9009 /* HTMLFormControlElementWithState.cpp in Sources */,

ditto.

[Andreas Kling]

(In reply to comment #4)
> (From update of attachment 121253 [details])
> We need to update html/HTMLElementsAllInOne.cpp.

Ratcakes! I always forget about those, sorry.

[Alexis Menard (darktears)]

Created attachment 121265 [details]
Patch V3

I hope I got it right this time :(.

[Alexis Menard (darktears)]

Created attachment 121269 [details]
Patch V3

Should be the right one now.

[Kent Tamura]

Comment on attachment 121269 [details]
Patch V3

Great.  Thanks!

[WebKit Review Bot]

Comment on attachment 121269 [details]
Patch V3

Clearing flags on attachment: 121269

Committed r104268: <http://trac.webkit.org/changeset/104268>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen, because it was rolled out (it broke the Mac build): http://trac.webkit.org/changeset/104272

[Kent Tamura]

Committed r104274: <http://trac.webkit.org/changeset/104274>

[Kent Tamura]

(In reply to comment #13)
> Committed r104274: <http://trac.webkit.org/changeset/104274>

I added
  settings = {ATTRIBUTES = (Private, ); };
for HTMLFormControlElementWithState.h in project.pbxproj.

[Alexis Menard (darktears)]

(In reply to comment #14)
> (In reply to comment #13)
> > Committed r104274: <http://trac.webkit.org/changeset/104274>
> 
> I added
>   settings = {ATTRIBUTES = (Private, ); };
> for HTMLFormControlElementWithState.h in project.pbxproj.

Sorry for the trouble.