Bug 75477 - [BlackBerry] Add startsWith to BlackBerry::WebKit::WebString
Summary: [BlackBerry] Add startsWith to BlackBerry::WebKit::WebString
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 08:47 PST by Mike Lattanzio
Modified: 2012-05-04 14:29 PDT (History)
2 users (show)

See Also:


Attachments
Add the startsWith method. (2.51 KB, patch)
2012-01-03 11:14 PST, Mike Lattanzio
no flags Details | Formatted Diff | Diff
Add startsWith, refactor equal and equalIgnoringCase, and add new blackberry ChangeLog (3.29 KB, patch)
2012-01-03 12:07 PST, Mike Lattanzio
tonikitoo: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lattanzio 2012-01-03 08:47:14 PST
The startsWith method is needed in BlackBerry::WebKit::WebString.
Comment 1 Mike Lattanzio 2012-01-03 11:14:00 PST
Created attachment 120967 [details]
Add the startsWith method.
Comment 2 Mike Lattanzio 2012-01-03 12:07:08 PST
Created attachment 120975 [details]
Add startsWith, refactor equal and equalIgnoringCase, and add new blackberry ChangeLog

This fixes the bug in question by providing the necessary API. 

It also refactors equal and equalIgnoringCase into an equals method with the same caseSensitive parameter, and adds a new ChangeLog file for WebKit/blackberry.
Comment 3 WebKit Review Bot 2012-01-03 12:10:08 PST
Attachment 120975 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
From git://git.webkit.org/WebKit
 + 15f9bcd...8e973cb master     -> origin/master  (forced update)
	M	LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt
	M	LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt
	M	LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html
	M	LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html
	M	LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt
	M	LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width.html
	A	LayoutTests/svg/custom/webkit-transform-crash.html
	A	LayoutTests/svg/custom/webkit-transform-crash-expected.txt
	M	LayoutTests/ChangeLog
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/platform/gtk/RenderThemeGtk3.cpp
	M	Source/WebCore/platform/gtk/ScrollbarThemeGtk3.cpp
	M	Source/WebCore/platform/mac/ThemeMac.mm
	M	Source/WebCore/svg/SVGStyledTransformableElement.cpp
	M	Source/WebCore/rendering/RenderLayer.cpp
	M	Source/WebCore/css/CSSComputedStyleDeclaration.h
	M	Source/WebCore/css/CSSComputedStyleDeclaration.cpp
	M	Tools/Scripts/webkitpy/layout_tests/port/win.py
	M	Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
	M	Tools/Scripts/webkitpy/layout_tests/port/mac.py
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py
	M	Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py
	M	Tools/Scripts/webkitpy/layout_tests/port/apple.py
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
	M	Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
	M	Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
	M	Tools/Scripts/webkitpy/layout_tests/port/base.py
	M	Tools/Scripts/webkitpy/layout_tests/port/test.py
	M	Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py
	M	Tools/Scripts/webkitpy/layout_tests/port/qt.py
	M	Tools/ChangeLog
r103955 = 6aab0dafec68b43a47f81ab79d03001e05e99b64 (refs/remotes/origin/master)
First, rewinding head to replay your work on top of it...
Applying: [GTK] GTK+ 3 theming code does not use the GtkOrientable style class
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [GTK] GTK+ 3 theming code does not use the GtkOrientable style class

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 158.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2012-01-03 17:19:18 PST
Comment on attachment 120975 [details]
Add startsWith, refactor equal and equalIgnoringCase, and add new blackberry ChangeLog

Rejecting attachment 120975 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 53, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/10954671
Comment 5 Rob Buis 2012-04-19 14:16:17 PDT
This seems to never have landed, do we still need it?
Comment 6 Mike Lattanzio 2012-05-04 14:29:49 PDT
(In reply to comment #5)
> This seems to never have landed, do we still need it?

No sir. A simple workaround ended up getting the job done. Closing.