RESOLVED FIXED 75472
[Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser 
https://bugs.webkit.org/show_bug.cgi?id=75472
Summary [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
Alexander Færøy
Reported 2012-01-03 07:55:10 PST
SSIA. Patch coming up.
Attachments
Patch (4.45 KB, patch)
2012-01-03 07:59 PST, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Færøy
Comment 1 2012-01-03 07:59:41 PST
Created attachment 120946 [details] Patch
Tor Arne Vestbø
Comment 2 2012-01-03 08:00:48 PST
Comment on attachment 120946 [details] Patch nice
WebKit Review Bot
Comment 3 2012-01-03 08:10:01 PST
Comment on attachment 120946 [details] Patch Rejecting attachment 120946 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: owser/qt/MiniBrowser.qrc Hunk #1 FAILED at 8. 1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/MiniBrowser.qrc.rej patching file Tools/MiniBrowser/qt/qml/BrowserWindow.qml Hunk #1 FAILED at 265. 1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/qml/BrowserWindow.qml.rej patching file Tools/MiniBrowser/qt/qml/ConfirmDialog.qml Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tor Arne Vestb\xf8', u..." exit_code: 1 Full output: http://queues.webkit.org/results/10954487
Alexander Færøy
Comment 4 2012-01-03 08:22:10 PST
Comment on attachment 120946 [details] Patch Requesting CQ again since the patch of which this patch depends upon has just landed.
WebKit Review Bot
Comment 5 2012-01-03 08:52:45 PST
Comment on attachment 120946 [details] Patch Clearing flags on attachment: 120946 Committed r103942: <http://trac.webkit.org/changeset/103942>
WebKit Review Bot
Comment 6 2012-01-03 08:52:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.