RESOLVED FIXED Bug 75465
[WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty 
https://bugs.webkit.org/show_bug.cgi?id=75465
Summary [WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty
Carlos Garcia Campos
Reported 2012-01-03 01:26:03 PST
Assuming unreachableURL is what the user should show in the location entry, the active URL of the page should be the unreachableURL when loadAlternateHTML has been used to load current page contents.
Attachments
Patch (1.25 KB, patch)
2012-01-03 01:28 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (2.31 KB, patch)
2012-01-05 04:00 PST, Carlos Garcia Campos 		pnormand: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-01-03 01:28:50 PST
Created attachment 120918 [details] Patch
Priit Laes (IRC: plaes)
Comment 2 2012-01-05 03:44:29 PST
(In reply to comment #1) > Created an attachment (id=120918) [details] > Patch Could you also remove the FIXME from WebViewTest::replaceContent in Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp ?
Carlos Garcia Campos
Comment 3 2012-01-05 03:49:41 PST
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=120918) [details] [details] > > Patch > > Could you also remove the FIXME from WebViewTest::replaceContent in Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp ? Sure
Carlos Garcia Campos
Comment 4 2012-01-05 04:00:18 PST
Created attachment 121255 [details] Updated patch It removes the workaround used to fix unit tests in r104129
WebKit Review Bot
Comment 5 2012-01-05 04:01:53 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Review Bot
Comment 6 2012-01-05 13:20:25 PST
Comment on attachment 121255 [details] Updated patch Attachment 121255 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11143062 New failing tests: http/tests/inspector/network/download.html
Carlos Garcia Campos
Comment 7 2012-03-05 06:46:17 PST
ping, could someone review this patch please?
Philippe Normand
Comment 8 2012-03-15 01:52:30 PDT
Comment on attachment 121255 [details] Updated patch LGTM
Carlos Garcia Campos
Comment 9 2012-03-15 02:09:17 PDT
Committed r110834: <http://trac.webkit.org/changeset/110834>
Note You need to log in before you can comment on or make changes to this bug.