This bug is for spliting GraphicsContext3DOpenGL into following files as Chris Marrin mentioned. +GraphicsContext3DOpenGLCommon - code common to any OpenGL implementation +GraphicsContext3DOpenGL - OpenGL (not OpenGL ES) specific code) +GraphicsContext3DGLES - OpenGL ES specific code
Created attachment 121852 [details] Patch
Created attachment 121862 [details] Patch
Created attachment 121866 [details] Patch
Comment on attachment 121866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121866&action=review > Source/WebCore/ChangeLog:13 > + > + Split GraphicsContext3DOpenGL.cpp into > + GraphicsContext3DOpenGLCommon.cpp, GraphicsContext3DOpenGL.cpp & GraphicsContext3DOpenGLES.cpp. > + Most of common APIs between gl and gles are in GraphicsContext3DOpenGLCommon.cpp. > + The other gl and gles specific APIs are placed apart in GraphicsContext3DOpenGL.cpp & GraphicsContext3DOpenGLES.cpp > + > + No new tests required. It would be good if you could write why this is an advantage. Also can you try to keep the lines shorter (around 80-100 chars)
Created attachment 122251 [details] Patch
Comment on attachment 121866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121866&action=review Thank you for review. :) >> Source/WebCore/ChangeLog:13 >> + No new tests required. > > It would be good if you could write why this is an advantage. Also can you try to keep the lines shorter (around 80-100 chars) Done.
Comment on attachment 122251 [details] Patch Nice refactoring. r=me
Comment on attachment 122251 [details] Patch Clearing flags on attachment: 122251 Committed r104896: <http://trac.webkit.org/changeset/104896>
All reviewed patches have been landed. Closing bug.