Bug 75453 - alignment issue when building with Solaris Studio
Summary: alignment issue when building with Solaris Studio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-02 16:50 PST by Pavel Heimlich (hajma)
Modified: 2012-01-16 02:23 PST (History)
1 user (show)

See Also:


Attachments
patch (640 bytes, patch)
2012-01-02 16:50 PST, Pavel Heimlich (hajma)
no flags Details | Formatted Diff | Diff
Patch (1.17 KB, patch)
2012-01-06 12:47 PST, Pavel Heimlich (hajma)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Heimlich (hajma) 2012-01-02 16:50:42 PST
Created attachment 120900 [details]
patch

building Qt 4.8 with Solaris Studio fails with the below message.

...
"./wtf/Alignment.h", line 33: Error: #error WTF_ALIGN macros need alignment control..

See also https://bugs.webkit.org/show_bug.cgi?id=57231, basically alignment macros are supported in Sun/Solaris Studio since v.12

I'm not sure from which webkit version comes the Qt snapshot, but I can see the same code is still present in webkit trunk.

The attached patch helped me.
Comment 1 Alexey Proskuryakov 2012-01-03 10:03:04 PST
Would you be willing to make a patch that could be reviewed and landed in WebKit trunk, as described in <http://www.webkit.org/coding/contributing.html>? We don't normally keep open bugs for patches that are not intended for landing.
Comment 2 Pavel Heimlich (hajma) 2012-01-06 12:47:33 PST
Created attachment 121473 [details]
Patch
Comment 3 Hajime Morrita 2012-01-16 01:35:51 PST
Comment on attachment 121473 [details]
Patch

Now this has a ChangeLog entry. Bots don't cry. Looks OK to land.
Comment 4 WebKit Review Bot 2012-01-16 02:23:18 PST
Comment on attachment 121473 [details]
Patch

Clearing flags on attachment: 121473

Committed r105044: <http://trac.webkit.org/changeset/105044>
Comment 5 WebKit Review Bot 2012-01-16 02:23:22 PST
All reviewed patches have been landed.  Closing bug.