Bug 75432 - [GTK] fast/dom/constructed-objects-prototypes.html fails
Summary: [GTK] fast/dom/constructed-objects-prototypes.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-02 03:17 PST by Philippe Normand
Modified: 2012-01-17 00:24 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2012-01-16 10:09 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-01-02 03:17:13 PST
Ryosuke rebaselined that test in r103644 and since then it fails on GTK:

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r103899%20(15555)/fast/dom/constructed-objects-prototypes-diff.txt

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/dom/constructed-objects-prototypes-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/dom/constructed-objects-prototypes-actual.txt 
@@ -41,8 +41,6 @@
 PASS (new inner.ProgressEvent()).constructor.isInner is true
 PASS (new inner.StorageEvent()).isInner is true
 PASS (new inner.StorageEvent()).constructor.isInner is true
-PASS (new inner.TrackEvent()).isInner is true
-PASS (new inner.TrackEvent()).constructor.isInner is true
 PASS (new inner.WebGLContextEvent()).isInner is true
 PASS (new inner.WebGLContextEvent()).constructor.isInner is true
 PASS (new inner.WebKitAnimationEvent()).isInner is true

I locally checked that enabling the text track at build time fixes the test. So I wonder, was this enabled on Mac recently? I disabled text track on GTK because the feature is still a moving target (AFAIK).

For now I'll commit GTK baselines for this test but this is a temporary solution.
Comment 1 Philippe Normand 2012-01-02 03:23:27 PST
Ah well, a test_expectations update was simpler :) 

http://trac.webkit.org/changeset/103901
Comment 2 Philippe Normand 2012-01-16 09:17:20 PST
(In reply to comment #1)
> Ah well, a test_expectations update was simpler :) 
> 
> http://trac.webkit.org/changeset/103901

Video track build was enabled on Mac in r103240... Hum I guess GTK should also enable it then, in build-webkit at least.
Comment 3 Philippe Normand 2012-01-16 10:09:25 PST
Created attachment 122660 [details]
Patch
Comment 4 Philippe Normand 2012-01-17 00:24:08 PST
Comment on attachment 122660 [details]
Patch

Clearing flags on attachment: 122660

Committed r105129: <http://trac.webkit.org/changeset/105129>
Comment 5 Philippe Normand 2012-01-17 00:24:15 PST
All reviewed patches have been landed.  Closing bug.