Bug 75426 - Add resolve-supplemental.pl to project.pbxproj
Summary: Add resolve-supplemental.pl to project.pbxproj
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency treegraph
 
Reported: 2012-01-01 21:49 PST by Kentaro Hara
Modified: 2012-01-02 19:51 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.32 KB, patch)
2012-01-02 05:28 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-01 21:49:20 PST
While I enabled the [Supplemental] IDL on AppleWebKit at the bug 74900, I forgot to add "resolve-supplemental.pl" to project.pbxproj. We should add it.
Comment 1 Kentaro Hara 2012-01-02 05:28:18 PST
Created attachment 120871 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-02 16:57:37 PST
Comment on attachment 120871 [details]
Patch

Clearing flags on attachment: 120871

Committed r103919: <http://trac.webkit.org/changeset/103919>
Comment 3 WebKit Review Bot 2012-01-02 16:57:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Mark Rowe (bdash) 2012-01-02 18:45:02 PST
If I'm reading this change correctly, it copies the Perl script in to WebCore.framework/Resources. Is that really what is intended from this change?
Comment 5 Adam Barth 2012-01-02 19:06:30 PST
resolve-supplemental.pl doesn't need to be in the final framework, but it would be nice to have it in the Xcode IDE.  Do we need to change some flags somewhere?  xcodeproj files are hard to read...
Comment 6 Mark Rowe (bdash) 2012-01-02 19:17:34 PST
The trick is to add it to the project without adding it to any target.  You can see that it is currently in a Copy Resources build phase by the "resolve-supplemental.pl in Resources" line that was added.  Fixing this is a simple matter of removing it from the WebCore target in Xcode.
Comment 7 Kentaro Hara 2012-01-02 19:19:41 PST
(In reply to comment #6)
> The trick is to add it to the project without adding it to any target.  You can see that it is currently in a Copy Resources build phase by the "resolve-supplemental.pl in Resources" line that was added.  Fixing this is a simple matter of removing it from the WebCore target in Xcode.

OK, let me try.
Comment 8 Kentaro Hara 2012-01-02 19:51:52 PST
(In reply to comment #7)
> (In reply to comment #6)
> > The trick is to add it to the project without adding it to any target.  You can see that it is currently in a Copy Resources build phase by the "resolve-supplemental.pl in Resources" line that was added.  Fixing this is a simple matter of removing it from the WebCore target in Xcode.
> 
> OK, let me try.

bdash: Uploaded a patch on bug 75458. By the way, "/* CodeGenerator.pm in Headers */" and "/* generate-bindings.pl in Headers */" are OK? Should we also remove them?