Bug 75424 - [EFL] Remove whitespace/declaration style exception
Summary: [EFL] Remove whitespace/declaration style exception
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-01 18:57 PST by Gyuyoung Kim
Modified: 2012-01-02 13:09 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.73 KB, patch)
2012-01-01 19:09 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (4.53 KB, patch)
2012-01-01 22:06 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-01-01 18:57:09 PST
EFL port doesn't violate whitespace/declaration coding style rule. So, this patch remove it from checker.py file.
Comment 1 Gyuyoung Kim 2012-01-01 19:09:56 PST
Created attachment 120853 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-01-01 20:10:22 PST
Looks OK, even though the changes to FrameLoaderClientEfl.cpp and ewk_frame.cpp aren't really whitespace/declaration fixes (but rather build/include_order and whitespace/braces, respectively).
Comment 3 Gyuyoung Kim 2012-01-01 20:48:55 PST
(In reply to comment #2)
> Looks OK, even though the changes to FrameLoaderClientEfl.cpp and ewk_frame.cpp aren't really whitespace/declaration fixes (but rather build/include_order and whitespace/braces, respectively).

Yes, right. when I test this patch on efl directory, there are some other style errors. So, I fix them together because they are trivial errors. I think it is better to fix on this bug together.
Comment 4 Gyuyoung Kim 2012-01-01 22:06:18 PST
Created attachment 120863 [details]
Patch
Comment 5 Gyuyoung Kim 2012-01-01 22:08:03 PST
I miss one thing. EWebLauncher and MiniBrowser are EFL simple application. So, I think they need to use EFL coding style continually. So, I keep *whitespace/declaration* exception for EWebLauncher and MiniBrowser.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-01-02 04:43:18 PST
Informal r+.
Comment 7 WebKit Review Bot 2012-01-02 13:09:49 PST
Comment on attachment 120863 [details]
Patch

Clearing flags on attachment: 120863

Committed r103911: <http://trac.webkit.org/changeset/103911>
Comment 8 WebKit Review Bot 2012-01-02 13:09:54 PST
All reviewed patches have been landed.  Closing bug.