RESOLVED FIXED 75420
[CMake] Clean up some cruft from wtf's CMakeLists.txt 
https://bugs.webkit.org/show_bug.cgi?id=75420
Summary [CMake] Clean up some cruft from wtf's CMakeLists.txt
Raphael Kubo da Costa (:rakuco)
Reported 2012-01-01 14:26:44 PST
[CMake] Clean up some cruft from wtf's CMakeLists.txt
Attachments
Patch (1.60 KB, patch)
2012-01-01 14:28 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Second attempt (2.80 KB, patch)
2012-01-01 16:22 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Third third is a charm: always add THIRDPARTY_DIR (1.75 KB, patch)
2012-01-09 11:10 PST, Raphael Kubo da Costa (:rakuco) 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-01-01 14:28:53 PST
Created attachment 120849 [details] Patch
Daniel Bates
Comment 2 2012-01-01 16:02:11 PST
Comment on attachment 120849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120849&action=review > Source/JavaScriptCore/ChangeLog:3 > + [CMake] Clean up some cruft from wtf's CMakeLists.txt Nit: wtf => WTF > Source/JavaScriptCore/wtf/CMakeLists.txt:-210 > - "${CMAKE_SOURCE_DIR}/Source/ThirdParty" Removing this line will break the build for ports that use the Mersenne Twister pseudorandom number generator, including the WinCE and BlackBerry ports. Notice the file Souece/ThirdParty/mt19937.ar.c is included in wtf/RandomNumber.cpp.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-01-01 16:22:37 PST
Created attachment 120852 [details] Second attempt
Daniel Bates
Comment 4 2012-01-03 11:42:37 PST
Comment on attachment 120852 [details] Second attempt Can you elaborate on how you came to the decision to move the include directory ${CMAKE_SOURCE_DIR}/Source/ThirdParty from Source/JavaScriptCore/wtf/CMakeLists.txt to Platform{BlackBerry, WinCE.cmake}?
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-01-04 08:32:40 PST
(In reply to comment #4) > (From update of attachment 120852 [details]) > Can you elaborate on how you came to the decision to move the include directory ${CMAKE_SOURCE_DIR}/Source/ThirdParty from Source/JavaScriptCore/wtf/CMakeLists.txt to Platform{BlackBerry, WinCE.cmake}? You had previously mentioned BlackBerry and WinCE needed ${THIRDPARTY_DIR} for the Mersenne Twister PRNG, so I moved it to the respective platform files instead of including it for all ports which use CMake.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-01-09 11:10:56 PST
Created attachment 121693 [details] Third third is a charm: always add THIRDPARTY_DIR
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-01-09 11:17:57 PST
Committed r104468: <http://trac.webkit.org/changeset/104468>
Note You need to log in before you can comment on or make changes to this bug.